summaryrefslogtreecommitdiffstats
path: root/tests
Commit message (Collapse)AuthorAgeFilesLines
...
* | Remove insignification of qsslsocket test on Windows and Mac.Jason McDonald2012-04-302-6/+3
| | | | | | | | | | | | | | | | | | | | | | | | The test has a single stable failure on both of these platforms. Mark the failure with QEXPECT_FAIL (that was already the case on Ubuntu 11.10) and re-enable the test. Note also the elimination of duplicate bug numbers. Task-number: QTBUG-24234 Change-Id: Ica11e7d1f3cd9487647127984fef7c75e0e764fe Reviewed-by: Shane Kearns <shane.kearns@accenture.com>
* | Simplify the cmake version check.Stephen Kelly2012-04-291-1/+1
| | | | | | | | | | | | Change-Id: Ifdd89397f88b090a6b43d40636dbeac029faaed8 Reviewed-by: Alexander Neundorf <neundorf@kde.org> Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
* | Add some more useful output when about the cmake versionStephen Kelly2012-04-291-1/+1
| | | | | | | | | | | | Change-Id: I58efa1f295dbc652b1882937ca27ea52d9f4a923 Reviewed-by: Alexander Neundorf <neundorf@kde.org> Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
* | Re-enable casting to and from "ASCII" on tst_qstring.cppThiago Macieira2012-04-281-33/+13
| | | | | | | | | | | | | | | | | | | | Turns out that we've had some old unit tests commented out that did not compile. QString does not have a std::string constructor nor overloads to many other methods. And std::string does not cast to char* on its own. So these tests need to be removed. Change-Id: I22df66fc3ccc68bc2840f2d83747234418e480f5 Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
* | Wrap the non-ASCII testcases with QString::fromUtf8Thiago Macieira2012-04-271-5/+5
| | | | | | | | | | | | | | And use QString::toUtf8() to recover the byte array original. Change-Id: Ic94de12e7ac67479e85a64a86f8467428b4d22ba Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
* | Wrap all Latin 1 strings with QString::fromLatin1 or QLatin1StringsThiago Macieira2012-04-276-47/+49
| | | | | | | | | | Change-Id: I1a1891b9126a2546c1872ec25aba9581cc84bb2f Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
* | Convert these files to ASCII or UTF-8Thiago Macieira2012-04-272-2/+2
| | | | | | | | | | | | | | Remove all non-UTF-8 sequences from source code in Qt. Change-Id: I46d9cb23ef2199894896f171d553b3144822f36c Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
* | Force tst_qstring to use fromLatin1 where it has Latin 1 literalsThiago Macieira2012-04-271-37/+39
| | | | | | | | | | Change-Id: I941d20733da2987ca7ced14c314adebaf6a431f6 Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
* | Fix QWindow autotest for Windows.Miikka Heikkinen2012-04-272-8/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The test was flawed, as it didn't process queued events before checking for received event counts, which caused window minimum size enforcement triggered resizes to be missed. Added event processing steps before critical checks and also increased the size of the windows so that event counts are predictable also on Windows. Note that this might also fix the issues this test has on Mac, but I can't test that. Task-number: QTBUG-24904 Change-Id: I01a4bd1ddabcf3650a8abff67b03c75b9c40a626 Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
* | Add QMetaMethod::fromSignal() functionKent Hansen2012-04-271-0/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Given a member function that's a signal, returns the corresponding QMetaMethod. Inspired by the implementation of the template-based QObject::connect(). The primary use case for this function is to have an effective and exact (not subject to shadowing) way of checking whether a known signal was connected to in reimplementations of QObject::connectNotify(QMetaMethod), avoiding string comparisons. Example: void MyObject::connectNotify(const QMetaMethod &signal) { if (signal == QMetaMethod::fromSignal(&MyObject::mySignal)) { // Someone connected to mySignal ... } } Change-Id: I5e4de434275fe543c004d569dcaa9ceda3442f03 Reviewed-by: Olivier Goffart <ogoffart@woboq.com> Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
* | Implement inline downscaling in png reader, to save memoryaavit2012-04-272-2/+4
| | | | | | | | | | | | | | | | | | Instead of allocating and reading the entire image and then scaling it down, this code reads only one line at a time and scales it on the fly. Change-Id: I61fde307146c11dcd90ca617cc2e7f85dd3b66c4 Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
* | Removed parallel_test from parallel-unsafe autotest.Rohan McGovern2012-04-271-1/+0
| | | | | | | | | | | | | | | | | | This autotest passes when run alone, but sometimes fails when run concurrently with other tests. Change-Id: I327de7f4a9f8af385351e4c6b09a57311efd6eb6 Reviewed-by: Toby Tomkins <toby.tomkins@nokia.com> Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
* | Respect the DontUseNativeDialog flag.Christoph Schleifenbaum2012-04-271-4/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | QFontDialog and QColorDialog were ignoring the DontUseNativeDialog. This lead to a native (Cocoa) dialog created all the time. Fix the testcase for QFontDialog. It needs the DontUseNativeDialog flag set. Task-number: QTBUG-24321 Change-Id: I159c1ad057bac38226f1e01a56b15f142650bfd8 Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
* | cmake: temporarily set tests/auto/cmake insignificant on macRohan McGovern2012-04-271-0/+6
| | | | | | | | | | | | | | | | | | cmake was installed on CI macs _after_ this test was added, causing the test to block unrelated changes. Temporarily disable it as previously agreed with Stephen Kelly. Change-Id: I079c0016a5e4a9a03ee1a0bae9a2e836c6b985d6 Reviewed-by: Toby Tomkins <toby.tomkins@nokia.com>
* | Uncomment qnetworkproxyfactory autotestShane Kearns2012-04-261-1/+1
| | | | | | | | | | | | | | | | | | It no longer requires hardcoded configuration, and it passes on linux, mac 10.6 and windows desktops Change-Id: Ibaa63520dade58ce13c23cf2aba3ddbc5be1c472 Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com> Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
* | Take account of spanned items in QTreeView when dragging.Stephen Kelly2012-04-261-0/+33
| | | | | | | | | | | | | | | | | | | | Also remove some code which has been unused since it was introduced in 32182d107fa75e5619ecc91a81f50626f429ebe1 Task-number: QTBUG-25140 Change-Id: Ic7053d68d8200f845c1ae330342d27af7275e057 Reviewed-by: Tarja Sundqvist <tarja.sundqvist@digia.com> Reviewed-by: David Faure <faure@kde.org>
* | Make QTimeLine test significant.Jason McDonald2012-04-261-1/+0
| | | | | | | | | | | | | | | | Known failures in this test are now handled by QEXPECT_FAIL. Task-number: QTBUG-24796 Change-Id: I12ba57370cf3df1a85a108fbbcdc9db2222491c1 Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* | Ensure that QUrl::{to,from}LocalPath encode/decode properlyThiago Macieira2012-04-261-1/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Unlike path(), toLocalFile() isn't reporting a URL component, so it should decode the percent-encoded characters fully. This extra decoding pass is meant to catch %00 to %1F, %7F and %25 (the percent sign itself). It also catches %80 to %FF, which aren't decoded because they don't form UTF-8 sequences. That means QUrl::toLocalFile() has undefined behaviour if the path contained non-UTF8 sequences. Task-number: QTBUG-25459 Change-Id: Iab5a0ba6afcfc4510e297984f2ffc208cedd752b Reviewed-by: Shane Kearns <shane.kearns@accenture.com>
* | Fix QRawFont autotest in WindowsMiikka Heikkinen2012-04-252-3/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | Can't use style name with Windows native font engine, so do the comparison using style in case multipleRawFontsFromData(). Also XFAILed the advances() case when using Freetype font engine in Windows, as some of the advances returned are one pixel wider than expected. Task-number: QTBUG-24197 Change-Id: Ib5fecd83a93908e57a4c82ffb5495a92474ce45a Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
* | Remove QMetaObjectExtraData and put everything into QMetaObjectOlivier Goffart2012-04-252-24/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | QMetaObjectExtraData was added when support for QMetaObject::newInstance was added. One needed a place to put the pointer to static_metacall in the QMetaObject. But as we break binary compatibility, one can change the size of QMetaObject, and put everything back inside QMetaObject's own structure. Meaning it is not required anymore to have one QMetaObjectExtraData instance per QMetaObject anymore. Change-Id: If0b8f586cbaf633eed10045adee3ba3366826c86 Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com> Reviewed-by: Kent Hansen <kent.hansen@nokia.com> Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@nokia.com>
* | Add comparison operators == and != for QMetaMethodKent Hansen2012-04-251-0/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | This is done in preparation of introducing the QObject::connectNotify(QMetaMethod) function. Together with the forthcoming QMetaMethod::fromSignal() function, which returns the QMetaMethod corresponding to a Qt/C++ signal (member function), the comparison operators provide an effective way of checking which signal was connected to. Change-Id: I2de48628c4884a7174fb8574895f272cb3fe5634 Reviewed-by: Olivier Goffart <ogoffart@woboq.com> Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
* | lance: Document all available command line options.Holger Hans Peter Freyther2012-04-251-2/+6
| | | | | | | | | | Change-Id: I0e0d95cb5988574c1ecfbe7423ac7388022101fb Reviewed-by: Girish Ramakrishnan <girish.1.ramakrishnan@nokia.com>
* | baselineserver: Fix compilation by removing PI_BuildKey from the sourceHolger Hans Peter Freyther2012-04-251-1/+0
| | | | | | | | | | | | | | | | | | The buildkey support was removed in 7493ee1c44a16dc3. This commit removed PI_BuildKey and most of the usages from the code. Change-Id: I971d68cd4377c358381983c1edcb98360936b698 Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com> Reviewed-by: Girish Ramakrishnan <girish.1.ramakrishnan@nokia.com>
* | Fix recursion in qwidget gdiPainting test.Friedemann Kleint2012-04-251-4/+10
| | | | | | | | | | Change-Id: If4881dfecc6fc7cebcd3ed896846d34e35b3e3ae Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
* | Skip tst_QInputDialog on Mac OS XBradley T. Hughes2012-04-251-0/+2
| | | | | | | | | | | | | | | | | | | | | | This test hangs in CI, but so far I've been unable to reproduce the problem. Disable the test for now so that this test does not block changes that bring in needed functionality. Task-number: QTBUG-25496 Change-Id: I81faa574b6d7bcab2e32becc2af0f71006c7dd9c Reviewed-by: Morten Johan Sørvig <morten.sorvig@nokia.com> Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
* | Revert QUrl::isRelative to its Qt 4 behaviourThiago Macieira2012-04-251-1/+1
| | | | | | | | | | | | | | | | | | Instead of trying to return whether the URL is relative to something undefined, let's instead follow what the documentation was saying all along and what the RFC says about "Relative References". Change-Id: I32722321a6b36c6e3480669ad769390e4c6f7d1c Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
* | get rid of QT_NO_IMAGE_TEXT switcherKonstantin Ritt2012-04-251-4/+0
| | | | | | | | | | Change-Id: Ie72f907ffb959f629af6a414959348a992c4c941 Reviewed-by: aavit <qt_aavit@ovi.com>
* | Mark known test failures in Windows developer build.Jason McDonald2012-04-251-0/+3
| | | | | | | | | | | | | | | | | | Previously, the CI system has not been testing on Windows with the -developer-build configure flag. Mark known failures for this configuration so that tests can be run in enforcing mode. Change-Id: I5fbbbe09a7b400d626107c66dcbd5c5469a45b20 Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
* | Use macro for QByteArrayData initialization.Jędrzej Nowacki2012-04-251-4/+4
| | | | | | | | | | Change-Id: Ib3f906dc5f313c7f9669efda26a93a76af7d7f80 Reviewed-by: João Abecasis <joao.abecasis@nokia.com>
* | Using QLatin1String instead of QLatin1LiteralDebao Zhang2012-04-252-6/+1
| | | | | | | | | | | | | | | | QLatin1Literal is just a typedef of QLatin1String. Change-Id: If20ca225e57a7fb45a7775f0fc81aedb6da88c96 Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
* | Ensure that QUrl::toLocalFile returns decoded pathsThiago Macieira2012-04-241-0/+1
| | | | | | | | | | | | | | | | | | | | | | QUrl::path() already decodes almost everything, but let's pass the formatting flag to be sure. Note: decoding of control characters from U+0001 to U+001F is not implemented. Non-UTF8 sequences are also not representable. Change-Id: I9a0ae2282ec3d48cc0e70e5b2d3824fb120709ed Reviewed-by: Shane Kearns <shane.kearns@accenture.com>
* | Don't use the QRegExp methods that modify the object [QtGui]Thiago Macieira2012-04-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | QRegExp matching methods modify the object, which we don't want to. In particular, when we receive a QRegExp from the user or we store in a context that might require thread-safety, make sure we make a copy before using it. QRegularExpression has no such shortcoming. Task-number: QTBUG-25064 Change-Id: If119e06221ca99e57c5ad1a1d4cc6468e9f68c7b Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
* | Don't strip the leading slash of letter+colon paths on UnixThiago Macieira2012-04-241-0/+4
| | | | | | | | | | | | | | | | | | It's perfectly valid to have a path of /c:/a.txt on Unix, so don't strip the leading slash unless we're on Windows. Task-number: QTBUG-20322 Change-Id: I721bd0a65b41048bc735d4eaa0d536174164fe64 Reviewed-by: Shane Kearns <shane.kearns@accenture.com>
* | Remove insignification from qabstractitemmodel test on Mac OS X.Jason McDonald2012-04-241-2/+0
| | | | | | | | | | | | | | | | | | Since this test began to run again on Mac, it has been passing consistently. Task-number: QTBUG-22748 Change-Id: Ia81cf60b11d45fb331b5eca5d13df00556c18e07 Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
* | lancelot test: Skip crashing test function on Mac OS X.Jason McDonald2012-04-241-0/+3
| | | | | | | | | | | | Task-number: QTBUG-22792 Change-Id: Iee70dafe9b4aced1a7c6cea63da88a92dff7d43d Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
* | Add a QWindow autotest case for reentrant mouse/touch eventsLaszlo Agocs2012-04-241-2/+55
| | | | | | | | | | | | | | | | | | | | Declarative used to have some issues when the MouseArea event handlers spinned the event loop: subsequent mouse events were all lost. Let's add an autotest also for QGuiApplication to make sure the same problem won't occur there. Change-Id: If5c3b4f58dad609efb302d2ca932493680ffdf13 Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
* | Run DBus tests only if QtDBus is found.Stephen Kelly2012-04-241-1/+4
| | | | | | | | | | | | | | | | | | It's not enough to check for UNIX because Qt may have been configured without dbus, or we could be running on APPLE (on which DBus is not commonly installed). Change-Id: Ic57200dad42c0c12b292d1066f799c827294fe9a Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
* | Re-enable network tests on Mac OS.Jason McDonald2012-04-244-13/+6
| | | | | | | | | | | | | | | | | | Switch on most of the tests (all but the bearer tests), marking the two known failures as insignificant tests. Change-Id: I17f228a938de1a23eddf897f494bfa4e54338dae Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com> Reviewed-by: Shane Kearns <shane.kearns@accenture.com>
* | Remove insignification of QMdiArea test on Windows.Jason McDonald2012-04-242-3/+3
| | | | | | | | | | | | | | | | | | This test had two stable failures, caused by including code not meant for Windows. Task-number: QTBUG-25298 Change-Id: I43d9d62ecf5a3c6eec240fafbc43a625c00f45fa Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
* | Re-enable the QMacStyle test.Jason McDonald2012-04-242-3/+3
| | | | | | | | | | | | | | | | | | This test has only stable failures. Mark those failures with QEXPECT_FAIL and re-enable the test. Task-number: QTBUG-25296 Change-Id: I5615700ec8119a827c30e43ae651a684e78170fe Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
* | Fix windowgeometry test for Windows.Friedemann Kleint2012-04-242-1/+4
| | | | | | | | | | | | | | | | | | - Specify main.cpp with full path to avoid obscure link errors (grabbing main.cpp from windowflags) - Set proper flags on the test window. Change-Id: I9bbaf9cb5c7e210f53a51b58bd48a827d6104fe2 Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
* | Remove insignification from QDateTimeEdit test on Mac OS X.Jason McDonald2012-04-242-1/+33
| | | | | | | | | | | | | | | | | | This test only has stable failures. Mark those with QEXPECT_FAIL and re-enable the test. Task-number: QTBUG-23674 Change-Id: I0e6cfe4f1992410bbc27b266f7bdafa14451aff7 Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
* | Remove insignification of QSizeGrip test on Mac OS X.Jason McDonald2012-04-242-2/+1
| | | | | | | | | | | | | | | | | | The test has one stable failure. Mark it with QEXPECT_FAIL and re-enable the test. Task-number: QTBUG-23681 Change-Id: Iade17cbbd1570863bb628572d8da52ec9c0f62ba Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
* | Skip unstable tst_QMdiArea::subWindowActivated2 test on Mac OS X.Jason McDonald2012-04-241-1/+1
| | | | | | | | | | | | | | | | | | This test function recently became unstable in parallel with the change to re-enable the test. Skip the unstable function until it can be fixed. Change-Id: I0fb962aa3294a0c9b799acee52ab1fb1cd1c6924 Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
* | Remove insignification of QMdiArea test on Mac OS X.Jason McDonald2012-04-232-1/+16
| | | | | | | | | | | | | | | | | | This test has only stable failures on Mac. Mark those failures with QEXPECT_FAIL and re-enable the test. Task-number: QTBUG-25298 Change-Id: I1c768226dfeb9307386e8853091baa68936bed29 Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
* | QSqlQueryModel::setQuery() don't use deprecated reset()Mark Brand2012-04-232-74/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously the method attempted to reset only as a last resort. Now reset() is deprecated and resetting must happen between emitting modelAboutToBeReset() and modelReset(). Since this suffices in all cases to notify views that they must reinterrogate the model, it is no longer necessary to signal explicitly row removals and insertions within the scope of the reset. Additionally, fetchMore() is now called within the scope of the reset so insert signals do not have to be emitted here either. This improved handling of resetting in QSqlQueryModel also allows the cache in QSqlTableModel to be cleared directly at select(). This change may actually allow views to operate more efficiently since they no longer have to react to separate row removal and insert signals. Views can avoid pointless deallocation and reallocation by considering row count only after the reset is finished. The cost is that the columns and horizontal headers must be considered in the view at each setQuery() call. In any case, it is not clear that trying to be smart about this in the model justifies additional complexity. Tests had to be adjusted where they expected explicit row removal and insert signals. Change-Id: I4f7eac1419824361d7d9bdcc6a87092b33e80d7a Task-Id: QTBUG-25419 Reviewed-by: Andy Shaw <andy.shaw@digia.com> Reviewed-by: Olivier Goffart <ogoffart@woboq.com> Reviewed-by: Honglei Zhang <honglei.zhang@nokia.com>
* | Move the CMake unit tests to auto/Stephen Kelly2012-04-2335-0/+51
| | | | | | | | | | | | | | | | | | | | This will allow the CI system to run the tests. The tests are only run if cmake is found. Change-Id: Ie73a56114c151871160bafcbf0b90b2d54620855 Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com> Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com> Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
* | Start running some disabled tests again on Mac OS.Jason McDonald2012-04-238-11/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | These tests were disabled when trying to get CI working on Mac OS because they asserted or crashed. Now that CI is working well on Mac OS, start running these tests again, initially as insignificant tests. CI results will then be used to determine whether the tests can be made significant. Change-Id: Ife411e6b8c84ade45c865ef35f3ae0071d6f8d2b Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com> Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com> Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* | Re-enable QGraphicsView test on Windows, Mac and Ubuntu 11.10.Jason McDonald2012-04-232-8/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On Windows, the test had a stable failure and an XPASS related to an already closed bug report. On Mac, the test had one stable failure, on the same statement that had the XPASS on Windows. On Ubuntu, the test has been passing consistently. Mark the stable failures with QEXPECT_FAIL, remove the QEXPECT_FAIL that causes the XPASS, and remove the insignificant_test markers to re-enable the test. Task-number: QTBUG-24296 Change-Id: I05dd16b39296919268fee216332929df591f2b66 Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* | Fix bug in qsslsocket peek()Kalle Viironen2012-04-231-0/+257
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Calling peek() for qsslsocket caused socket data to be copied into qiodevices buffer and therefore make it unaccessible in qsslsocket. Cherry picked form 4.8-branch & modified to Qt5 API changes (int -> qintptr) Original commits: commit 621f18955082fc73471e75d1f8c35c2dcd4befeb Author: Shane Kearns <ext-shane.2.kearns@nokia.com> commit 68b1d5c17aa38d5921bdade2b0e0cb67c6c90513 Author: Kalle Viironen <kalle.viironen@digia.com> Task-number: QTBUG-18498 Change-Id: I6be4b19baec2f3197537f5e7b61432040ec84ad2 Reviewed-by: Shane Kearns <shane.kearns@accenture.com> Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>