From 0b3e45fa0ae40e1271256a134effbcc5f3e99017 Mon Sep 17 00:00:00 2001 From: Anton Kudryavtsev Date: Mon, 11 Apr 2016 15:33:41 +0300 Subject: Use takeFirst() instead of first() with removeFirst() Reduce code size and improve readability. Change-Id: I5ec035a39cb607f15748aaa08d73f1c1bc8e4ad8 Reviewed-by: Oswald Buddenhagen Reviewed-by: Thiago Macieira --- src/corelib/io/qprocess.cpp | 6 ++---- src/widgets/itemviews/qheaderview.cpp | 3 +-- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/corelib/io/qprocess.cpp b/src/corelib/io/qprocess.cpp index 6f11d0892f..0a0fef4cd8 100644 --- a/src/corelib/io/qprocess.cpp +++ b/src/corelib/io/qprocess.cpp @@ -2309,8 +2309,7 @@ void QProcess::start(const QString &command, OpenMode mode) return; } - QString prog = args.first(); - args.removeFirst(); + const QString prog = args.takeFirst(); start(prog, args, mode); } @@ -2552,8 +2551,7 @@ bool QProcess::startDetached(const QString &command) if (args.isEmpty()) return false; - QString prog = args.first(); - args.removeFirst(); + const QString prog = args.takeFirst(); return QProcessPrivate::startDetached(prog, args); } diff --git a/src/widgets/itemviews/qheaderview.cpp b/src/widgets/itemviews/qheaderview.cpp index e046e4781f..9306b20043 100644 --- a/src/widgets/itemviews/qheaderview.cpp +++ b/src/widgets/itemviews/qheaderview.cpp @@ -3377,8 +3377,7 @@ void QHeaderViewPrivate::resizeSections(QHeaderView::ResizeMode globalMode, bool } section_sizes.removeFirst(); } else { - newSectionLength = section_sizes.front(); - section_sizes.removeFirst(); + newSectionLength = section_sizes.takeFirst(); } } -- cgit v1.2.3