From 0d4fb41e8c00263a0d385b70cc066776cbf6cc37 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A5rten=20Nordheim?= Date: Wed, 17 Feb 2021 13:59:29 +0100 Subject: QNetworkInformation: Address API review feedback Added missing NOTIFY for Q_PROPERTY. Switched one Q_ENUM to Q_FLAG. Declared missing operators for QFlag. Pick-to: 6.1 Change-Id: I8e6756838e44e205844a34c95f436df6b51a862f Reviewed-by: Edward Welbourne Reviewed-by: Thiago Macieira --- src/network/kernel/qnetworkinformation.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/network/kernel/qnetworkinformation.h b/src/network/kernel/qnetworkinformation.h index a04e725300..bc71b37c64 100644 --- a/src/network/kernel/qnetworkinformation.h +++ b/src/network/kernel/qnetworkinformation.h @@ -53,7 +53,7 @@ class Q_NETWORK_EXPORT QNetworkInformation : public QObject { Q_OBJECT Q_DECLARE_PRIVATE(QNetworkInformation) - Q_PROPERTY(Reachability reachability READ reachability) + Q_PROPERTY(Reachability reachability READ reachability NOTIFY reachabilityChanged) public: enum class Reachability { Unknown, @@ -67,8 +67,8 @@ public: enum class Feature { Reachability = 0x1, }; - Q_ENUM(Feature) Q_DECLARE_FLAGS(Features, Feature) + Q_FLAG(Features) ~QNetworkInformation() override; @@ -93,6 +93,8 @@ private: Q_DISABLE_COPY_MOVE(QNetworkInformation) }; +Q_DECLARE_OPERATORS_FOR_FLAGS(QNetworkInformation::Features) + QT_END_NAMESPACE #endif -- cgit v1.2.3