From 25fb41a58ce20894526573c38e3afa742e86e29d Mon Sep 17 00:00:00 2001 From: Friedemann Kleint Date: Mon, 8 Jun 2015 14:52:40 +0200 Subject: QTest::qExtractTestData(): Set permissions of extracted files. Currently, the files are extracted with read-only permissions. If the data are extracted under a temporary directory, this prevents it from being deleted, causing a leak and test failures (for example, tst_qfileinfo). Change-Id: Idc85f31265af234446ed21d736e9a2b9866dc62d Reviewed-by: Simon Hausmann --- src/testlib/qtestcase.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/testlib/qtestcase.cpp b/src/testlib/qtestcase.cpp index e3c543671b..9329cf48af 100644 --- a/src/testlib/qtestcase.cpp +++ b/src/testlib/qtestcase.cpp @@ -2839,6 +2839,10 @@ QString QTest::qExtractTestData(const QString &dirName) qWarning("Failed to copy '%s'.", qPrintable(fileInfo.filePath())); return QString(); } + if (!QFile::setPermissions(destination, QFile::ReadUser | QFile::WriteUser | QFile::ReadGroup)) { + qWarning("Failed to set permissions on '%s'.", qPrintable(destination)); + return QString(); + } } } -- cgit v1.2.3