From 2a9d3b7a46ce822478d7845f92dc0edc677a2dfb Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Wed, 26 Mar 2014 15:18:32 +0100 Subject: QStringList: remove copy ctor The compiler-generated one is just fine, and enables the move constructor inherited from QList, too. This is BC and SC since QStringList isn't exported. Change-Id: Ic49000d9feb66504d7ec7e5d519e7a13ca9e5d9e Reviewed-by: Olivier Goffart Reviewed-by: Thiago Macieira --- src/corelib/tools/qstringlist.cpp | 14 -------------- src/corelib/tools/qstringlist.h | 1 - 2 files changed, 15 deletions(-) diff --git a/src/corelib/tools/qstringlist.cpp b/src/corelib/tools/qstringlist.cpp index 6b0b39c7bb..3f63b3b8e7 100644 --- a/src/corelib/tools/qstringlist.cpp +++ b/src/corelib/tools/qstringlist.cpp @@ -190,20 +190,6 @@ QT_BEGIN_NAMESPACE \sa append() */ -/*! - \fn QStringList::QStringList(const QStringList &other) - - Constructs a copy of the \a other string list. - - This operation takes \l{constant time} because QStringList is - \l{implicitly shared}, making the process of returning a - QStringList from a function very fast. If a shared instance is - modified, it will be copied (copy-on-write), and that takes - \l{linear time}. - - \sa operator=() -*/ - /*! \fn QStringList::QStringList(const QList &other) diff --git a/src/corelib/tools/qstringlist.h b/src/corelib/tools/qstringlist.h index a962b7c528..11a4d87890 100644 --- a/src/corelib/tools/qstringlist.h +++ b/src/corelib/tools/qstringlist.h @@ -63,7 +63,6 @@ class QStringList : public QList public: inline QStringList() { } inline explicit QStringList(const QString &i) { append(i); } - inline QStringList(const QStringList &l) : QList(l) { } inline QStringList(const QList &l) : QList(l) { } #ifdef Q_COMPILER_INITIALIZER_LISTS inline QStringList(std::initializer_list args) : QList(args) { } -- cgit v1.2.3