From 31849db9c678597ce1f7b86fa6b0d34541aa69fd Mon Sep 17 00:00:00 2001 From: Thiago Macieira Date: Thu, 18 Feb 2021 10:54:58 -0800 Subject: QProcess::startDetached/Unix: fix the resetting of SIGPIPE This should have been SIG_DFL, as we're about to execute a child process. It's the child's responsibility to ignore SIGPIPE if it wants to, or get killed by it when it writes to an pipe with no readers. Qt itself does this for its own purposes (see qt_ignore_sigpipe() [until I can get some time to teach Linux about O_NOSIGPIPE]). Therefore, we ought to reset what we've done. Change-Id: Ic90d8429a0eb4837971dfffd166585a686790dde Reviewed-by: Oswald Buddenhagen (cherry picked from commit f4e3b073b3d2a50133d734dd604bff21f061a3e6) --- src/corelib/io/qprocess_unix.cpp | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/corelib/io/qprocess_unix.cpp b/src/corelib/io/qprocess_unix.cpp index 8c6a095844..f235ab1320 100644 --- a/src/corelib/io/qprocess_unix.cpp +++ b/src/corelib/io/qprocess_unix.cpp @@ -911,11 +911,7 @@ bool QProcessPrivate::startDetached(qint64 *pid) pid_t childPid = fork(); if (childPid == 0) { - struct sigaction noaction; - memset(&noaction, 0, sizeof(noaction)); - noaction.sa_handler = SIG_IGN; - ::sigaction(SIGPIPE, &noaction, nullptr); - + ::signal(SIGPIPE, SIG_DFL); // reset the signal that we ignored ::setsid(); qt_safe_close(startedPipe[0]); -- cgit v1.2.3