From 358c12d92861d77fb4b1d2b7550c66d6ffb41b61 Mon Sep 17 00:00:00 2001 From: Stephen Kelly Date: Tue, 24 Jul 2012 16:22:03 +0200 Subject: De-inline QItemEditorCreatorBase destructor. Virtual destructors on public exported API should not be inline. Change-Id: I05bff0412ac97d2d8bd3cf8944f4fff2cb619f54 Reviewed-by: Thiago Macieira Reviewed-by: Olivier Goffart --- src/widgets/itemviews/qitemeditorfactory.cpp | 4 ++++ src/widgets/itemviews/qitemeditorfactory.h | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/widgets/itemviews/qitemeditorfactory.cpp b/src/widgets/itemviews/qitemeditorfactory.cpp index f970a77ab4..7ab34a6059 100644 --- a/src/widgets/itemviews/qitemeditorfactory.cpp +++ b/src/widgets/itemviews/qitemeditorfactory.cpp @@ -358,6 +358,10 @@ void QItemEditorFactory::setDefaultFactory(QItemEditorFactory *factory) Destroys the editor creator object. */ +QItemEditorCreatorBase::~QItemEditorCreatorBase() +{ + +} /*! \fn QWidget *QItemEditorCreatorBase::createWidget(QWidget *parent) const diff --git a/src/widgets/itemviews/qitemeditorfactory.h b/src/widgets/itemviews/qitemeditorfactory.h index 8bc1cc7df6..a57d7661fb 100644 --- a/src/widgets/itemviews/qitemeditorfactory.h +++ b/src/widgets/itemviews/qitemeditorfactory.h @@ -59,7 +59,7 @@ class QWidget; class Q_WIDGETS_EXPORT QItemEditorCreatorBase { public: - virtual ~QItemEditorCreatorBase() {} + virtual ~QItemEditorCreatorBase(); virtual QWidget *createWidget(QWidget *parent) const = 0; virtual QByteArray valuePropertyName() const = 0; -- cgit v1.2.3