From 396e3a18d766c51f4422c5729a4baba1fb1538fa Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Thu, 27 Mar 2014 17:30:10 +0100 Subject: QNX: don't copy a QStringList twice every loop iteration Apparently, the function before returned const-&, but now returns by-value. Use the member data variable directly, the function is const anyway. Change-Id: I324bc675fd7c9b5bfb28c475eba0c0275379132c Reviewed-by: Rafael Roquetto --- src/plugins/platforms/qnx/qqnxfilepicker.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/plugins/platforms/qnx/qqnxfilepicker.cpp b/src/plugins/platforms/qnx/qqnxfilepicker.cpp index 830b110f2a..f38b2dee88 100644 --- a/src/plugins/platforms/qnx/qqnxfilepicker.cpp +++ b/src/plugins/platforms/qnx/qqnxfilepicker.cpp @@ -288,8 +288,8 @@ QString QQnxFilePicker::filePickerType() const bool video = false; bool music = false; QMimeDatabase mimeDb; - for (int i = 0; i < filters().count(); i++) { - QList mimeTypes = mimeDb.mimeTypesForFileName(filters().at(i)); + for (int i = 0; i < m_filters.count(); i++) { + QList mimeTypes = mimeDb.mimeTypesForFileName(m_filters.at(i)); if (mimeTypes.isEmpty()) return QStringLiteral("Other"); -- cgit v1.2.3