From 5b1aa4c75de4301d1417fd98bb1abf0767779736 Mon Sep 17 00:00:00 2001 From: Xizhi Zhu Date: Fri, 13 Jan 2012 20:05:49 +0200 Subject: Fixed build break when bearer is disabled. Change-Id: I29e88b046f6502c84acc9c6f566ecc328cf24e38 Reviewed-by: Peter Hartmann --- src/network/access/qnetworkreplyhttpimpl.cpp | 4 ++++ src/network/kernel/qhostinfo.cpp | 2 ++ src/network/kernel/qhostinfo_p.h | 2 ++ .../access/qnetworkaccessmanager/tst_qnetworkaccessmanager.cpp | 8 +++++++- tests/auto/network/access/qnetworkreply/tst_qnetworkreply.cpp | 2 ++ .../bearer/qnetworkconfiguration/tst_qnetworkconfiguration.cpp | 7 +++++++ .../tst_qnetworkconfigurationmanager.cpp | 6 ++++++ tests/auto/network/bearer/qnetworksession/lackey/main.cpp | 4 ++++ .../bearer/qnetworksession/test/tst_qnetworksession.cpp | 10 ++++++++-- .../network/kernel/qnetworkinterface/tst_qnetworkinterface.cpp | 4 +++- tests/auto/network/socket/qudpsocket/tst_qudpsocket.cpp | 2 ++ 11 files changed, 47 insertions(+), 4 deletions(-) diff --git a/src/network/access/qnetworkreplyhttpimpl.cpp b/src/network/access/qnetworkreplyhttpimpl.cpp index cd142bfb0a..2c1ad95ea8 100644 --- a/src/network/access/qnetworkreplyhttpimpl.cpp +++ b/src/network/access/qnetworkreplyhttpimpl.cpp @@ -1497,10 +1497,12 @@ void QNetworkReplyHttpImplPrivate::setResumeOffset(quint64 offset) */ bool QNetworkReplyHttpImplPrivate::start() { +#ifndef QT_NO_BEARERMANAGEMENT if (!managerPrivate->networkSession) { postRequest(); return true; } +#endif // This is not ideal. const QString host = url.host(); @@ -1511,11 +1513,13 @@ bool QNetworkReplyHttpImplPrivate::start() return true; } +#ifndef QT_NO_BEARERMANAGEMENT if (managerPrivate->networkSession->isOpen() && managerPrivate->networkSession->state() == QNetworkSession::Connected) { postRequest(); return true; } +#endif return false; } diff --git a/src/network/kernel/qhostinfo.cpp b/src/network/kernel/qhostinfo.cpp index 1361799a4d..45073f6ad1 100644 --- a/src/network/kernel/qhostinfo.cpp +++ b/src/network/kernel/qhostinfo.cpp @@ -248,10 +248,12 @@ QHostInfo QHostInfoPrivate::fromName(const QString &name, QSharedPointer) { return QHostInfoAgent::fromName(hostName); } +#endif /*! diff --git a/src/network/kernel/qhostinfo_p.h b/src/network/kernel/qhostinfo_p.h index deb76c0ee9..35de89c1e9 100644 --- a/src/network/kernel/qhostinfo_p.h +++ b/src/network/kernel/qhostinfo_p.h @@ -95,7 +95,9 @@ class QHostInfoAgent : public QObject Q_OBJECT public: static QHostInfo fromName(const QString &hostName); +#ifndef QT_NO_BEARERMANAGEMENT static QHostInfo fromName(const QString &hostName, QSharedPointer networkSession); +#endif }; class QHostInfoPrivate diff --git a/tests/auto/network/access/qnetworkaccessmanager/tst_qnetworkaccessmanager.cpp b/tests/auto/network/access/qnetworkaccessmanager/tst_qnetworkaccessmanager.cpp index 5b10123b56..9fda95821e 100644 --- a/tests/auto/network/access/qnetworkaccessmanager/tst_qnetworkaccessmanager.cpp +++ b/tests/auto/network/access/qnetworkaccessmanager/tst_qnetworkaccessmanager.cpp @@ -42,11 +42,15 @@ #include #include +#ifndef QT_NO_BEARERMANAGEMENT #include +#endif #include -Q_DECLARE_METATYPE(QNetworkAccessManager::NetworkAccessibility); +#ifndef QT_NO_BEARERMANAGEMENT +Q_DECLARE_METATYPE(QNetworkAccessManager::NetworkAccessibility) +#endif class tst_QNetworkAccessManager : public QObject { @@ -65,6 +69,7 @@ tst_QNetworkAccessManager::tst_QNetworkAccessManager() void tst_QNetworkAccessManager::networkAccessible() { +#ifndef QT_NO_BEARERMANAGEMENT QNetworkAccessManager manager; qRegisterMetaType("QNetworkAccessManager::NetworkAccessibility"); @@ -105,6 +110,7 @@ void tst_QNetworkAccessManager::networkAccessible() QNetworkAccessManager::NotAccessible); QCOMPARE(manager.networkAccessible(), QNetworkAccessManager::NotAccessible); } +#endif } QTEST_MAIN(tst_QNetworkAccessManager) diff --git a/tests/auto/network/access/qnetworkreply/tst_qnetworkreply.cpp b/tests/auto/network/access/qnetworkreply/tst_qnetworkreply.cpp index 6fae97dc6d..9d3c8a7f2f 100644 --- a/tests/auto/network/access/qnetworkreply/tst_qnetworkreply.cpp +++ b/tests/auto/network/access/qnetworkreply/tst_qnetworkreply.cpp @@ -1315,9 +1315,11 @@ void tst_QNetworkReply::cleanupTestCase() #if !defined Q_OS_WIN QFile::remove(wronlyFileName); #endif +#ifndef QT_NO_BEARERMANAGEMENT if (networkSession && networkSession->isOpen()) { networkSession->close(); } +#endif } void tst_QNetworkReply::init() diff --git a/tests/auto/network/bearer/qnetworkconfiguration/tst_qnetworkconfiguration.cpp b/tests/auto/network/bearer/qnetworkconfiguration/tst_qnetworkconfiguration.cpp index f4dd6191b2..2a05f6132a 100644 --- a/tests/auto/network/bearer/qnetworkconfiguration/tst_qnetworkconfiguration.cpp +++ b/tests/auto/network/bearer/qnetworkconfiguration/tst_qnetworkconfiguration.cpp @@ -42,8 +42,10 @@ #include #include "../qbearertestcommon.h" +#ifndef QT_NO_BEARERMANAGEMENT #include #include +#endif /* Although this unit test doesn't use QNetworkAccessManager @@ -53,17 +55,21 @@ #include QT_USE_NAMESPACE + class tst_QNetworkConfiguration : public QObject { Q_OBJECT private slots: +#ifndef QT_NO_BEARERMANAGEMENT void invalidPoint(); void comparison(); void children(); void isRoamingAvailable(); +#endif }; +#ifndef QT_NO_BEARERMANAGEMENT void tst_QNetworkConfiguration::invalidPoint() { QNetworkConfiguration pt; @@ -188,6 +194,7 @@ void tst_QNetworkConfiguration::isRoamingAvailable() } } } +#endif QTEST_MAIN(tst_QNetworkConfiguration) #include "tst_qnetworkconfiguration.moc" diff --git a/tests/auto/network/bearer/qnetworkconfigurationmanager/tst_qnetworkconfigurationmanager.cpp b/tests/auto/network/bearer/qnetworkconfigurationmanager/tst_qnetworkconfigurationmanager.cpp index 7366e0adc1..c801534a50 100644 --- a/tests/auto/network/bearer/qnetworkconfigurationmanager/tst_qnetworkconfigurationmanager.cpp +++ b/tests/auto/network/bearer/qnetworkconfigurationmanager/tst_qnetworkconfigurationmanager.cpp @@ -42,8 +42,10 @@ #include #include "../qbearertestcommon.h" +#ifndef QT_NO_BEARERMANAGEMENT #include #include +#endif QT_USE_NAMESPACE class tst_QNetworkConfigurationManager : public QObject @@ -51,12 +53,15 @@ class tst_QNetworkConfigurationManager : public QObject Q_OBJECT private slots: +#ifndef QT_NO_BEARERMANAGEMENT void usedInThread(); // this test must be first, or it will falsely pass void allConfigurations(); void defaultConfiguration(); void configurationFromIdentifier(); +#endif }; +#ifndef QT_NO_BEARERMANAGEMENT void printConfigurationDetails(const QNetworkConfiguration& p) { qDebug() << p.name() <<": isvalid->" <"<< p.type() << @@ -245,6 +250,7 @@ void tst_QNetworkConfigurationManager::usedInThread() //QCOMPARE(thread.preScanConfigs, preScanConfigs); #endif } +#endif QTEST_MAIN(tst_QNetworkConfigurationManager) #include "tst_qnetworkconfigurationmanager.moc" diff --git a/tests/auto/network/bearer/qnetworksession/lackey/main.cpp b/tests/auto/network/bearer/qnetworksession/lackey/main.cpp index 2631e06f64..1182454fda 100644 --- a/tests/auto/network/bearer/qnetworksession/lackey/main.cpp +++ b/tests/auto/network/bearer/qnetworksession/lackey/main.cpp @@ -43,9 +43,11 @@ #include #include +#ifndef QT_NO_BEARERMANAGEMENT #include #include #include +#endif #include #include @@ -62,6 +64,7 @@ int main(int argc, char** argv) { QCoreApplication app(argc, argv); +#ifndef QT_NO_BEARERMANAGEMENT // Update configurations so that everything is up to date for this process too. // Event loop is used to wait for awhile. QNetworkConfigurationManager manager; @@ -150,6 +153,7 @@ int main(int argc, char** argv) oopSocket.disconnectFromServer(); oopSocket.waitForDisconnected(-1); +#endif return 0; } diff --git a/tests/auto/network/bearer/qnetworksession/test/tst_qnetworksession.cpp b/tests/auto/network/bearer/qnetworksession/test/tst_qnetworksession.cpp index ceedd17064..26bdec5c9b 100644 --- a/tests/auto/network/bearer/qnetworksession/test/tst_qnetworksession.cpp +++ b/tests/auto/network/bearer/qnetworksession/test/tst_qnetworksession.cpp @@ -45,27 +45,31 @@ #include #include "../../qbearertestcommon.h" +#ifndef QT_NO_BEARERMANAGEMENT #include #include +#endif QT_USE_NAMESPACE // Can be used to configure tests that require manual attention (such as roaming) //#define QNETWORKSESSION_MANUAL_TESTS 1 +#ifndef QT_NO_BEARERMANAGEMENT Q_DECLARE_METATYPE(QNetworkConfiguration) Q_DECLARE_METATYPE(QNetworkConfiguration::Type) +#endif class tst_QNetworkSession : public QObject { Q_OBJECT +#ifndef QT_NO_BEARERMANAGEMENT public slots: void initTestCase(); void cleanupTestCase(); private slots: - void robustnessBombing(); void sessionClosing_data(); @@ -92,8 +96,10 @@ private slots: private: QNetworkConfigurationManager manager; int inProcessSessionManagementCount; +#endif }; +#ifndef QT_NO_BEARERMANAGEMENT // Helper functions bool openSession(QNetworkSession *session); bool closeSession(QNetworkSession *session, bool lastSessionOnConfiguration = true); @@ -1250,7 +1256,7 @@ void tst_QNetworkSession::sessionAutoClose() QCOMPARE(autoCloseSession.toInt(), -1); } +#endif QTEST_MAIN(tst_QNetworkSession) - #include "tst_qnetworksession.moc" diff --git a/tests/auto/network/kernel/qnetworkinterface/tst_qnetworkinterface.cpp b/tests/auto/network/kernel/qnetworkinterface/tst_qnetworkinterface.cpp index da48b4907a..9a82be67a7 100644 --- a/tests/auto/network/kernel/qnetworkinterface/tst_qnetworkinterface.cpp +++ b/tests/auto/network/kernel/qnetworkinterface/tst_qnetworkinterface.cpp @@ -45,8 +45,10 @@ #include #include #include +#ifndef QT_NO_BEARERMANAGEMENT #include #include +#endif #include "../../../network-settings.h" class tst_QNetworkInterface : public QObject @@ -68,7 +70,7 @@ private slots: void copyInvalidInterface(); private: -#ifndef QT_NO_BEARER_MANAGEMENT +#ifndef QT_NO_BEARERMANAGEMENT QNetworkConfigurationManager *netConfMan; QNetworkConfiguration networkConfiguration; QScopedPointer networkSession; diff --git a/tests/auto/network/socket/qudpsocket/tst_qudpsocket.cpp b/tests/auto/network/socket/qudpsocket/tst_qudpsocket.cpp index b51e24b9a5..fb23483451 100644 --- a/tests/auto/network/socket/qudpsocket/tst_qudpsocket.cpp +++ b/tests/auto/network/socket/qudpsocket/tst_qudpsocket.cpp @@ -63,7 +63,9 @@ Q_DECLARE_METATYPE(QHostAddress) Q_DECLARE_METATYPE(QNetworkInterface) +#ifndef QT_NO_BEARERMANAGEMENT Q_DECLARE_METATYPE(QSharedPointer) +#endif QT_FORWARD_DECLARE_CLASS(QUdpSocket) -- cgit v1.2.3