From 6fd163f627f26e3c4fd1019772a4eafffb8f716f Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Fri, 10 Mar 2023 18:38:14 +0100 Subject: tracegen: fix inefficient loops MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Take the loop variable by cref. Amends 83effb3a3f6bf73e682f7a9ccedebf4073ade776. Pick-to: 6.5 Coverity-Id: 404701 Change-Id: I1266dd1feb16b3842a93169e554a6563861f5a14 Reviewed-by: Antti Määttä --- src/tools/tracegen/helpers.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tools/tracegen/helpers.h b/src/tools/tracegen/helpers.h index 11a1c809f3..00a1f99686 100644 --- a/src/tools/tracegen/helpers.h +++ b/src/tools/tracegen/helpers.h @@ -24,7 +24,7 @@ template static QString aggregateListValues(int value, const QList &list) { QStringList values; - for (auto l : list) { + for (const T &l : list) { if (l.value == value) values << l.name; } -- cgit v1.2.3