From 874eb8b44b3ca9cfab63372af10886d16dfc327d Mon Sep 17 00:00:00 2001 From: Anton Kudryavtsev Date: Thu, 12 May 2016 19:02:33 +0300 Subject: QtNetwork: use QStringRef to optimize memory allocation Replace substring functions that return QString with corresponding functions that return QStringRef where it's possible. Change-Id: Id7f70e5bd72c91ed210ec463aad1d84fe3b40c15 Reviewed-by: Timur Pocheptsov --- src/network/access/qftp.cpp | 2 +- src/network/access/qnetworkcookiejar.cpp | 2 +- src/network/kernel/qhostaddress.cpp | 2 +- src/network/kernel/qnetworkproxy_win.cpp | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/network/access/qftp.cpp b/src/network/access/qftp.cpp index 23ec390ae5..19b519243c 100644 --- a/src/network/access/qftp.cpp +++ b/src/network/access/qftp.cpp @@ -1218,7 +1218,7 @@ bool QFtpPI::startNextCmd() pendingCommands.pop_front(); #if defined(QFTPPI_DEBUG) - qDebug("QFtpPI send: %s", currentCmd.left(currentCmd.length()-2).toLatin1().constData()); + qDebug("QFtpPI send: %s", currentCmd.leftRef(currentCmd.length() - 2).toLatin1().constData()); #endif state = Waiting; commandSocket.write(currentCmd.toUtf8()); diff --git a/src/network/access/qnetworkcookiejar.cpp b/src/network/access/qnetworkcookiejar.cpp index 283dd3509e..429b71eb21 100644 --- a/src/network/access/qnetworkcookiejar.cpp +++ b/src/network/access/qnetworkcookiejar.cpp @@ -160,7 +160,7 @@ static inline bool isParentDomain(const QString &domain, const QString &referenc if (!reference.startsWith(QLatin1Char('.'))) return domain == reference; - return domain.endsWith(reference) || domain == reference.mid(1); + return domain.endsWith(reference) || domain == reference.midRef(1); } /*! diff --git a/src/network/kernel/qhostaddress.cpp b/src/network/kernel/qhostaddress.cpp index 2c09e63d6e..13ecfac3f5 100644 --- a/src/network/kernel/qhostaddress.cpp +++ b/src/network/kernel/qhostaddress.cpp @@ -1015,7 +1015,7 @@ QPair QHostAddress::parseSubnet(const QString &subnet) netmask = parser.prefixLength(); } else { bool ok; - netmask = subnet.mid(slash + 1).toUInt(&ok); + netmask = subnet.midRef(slash + 1).toUInt(&ok); if (!ok) return invalid; // failed to parse the subnet } diff --git a/src/network/kernel/qnetworkproxy_win.cpp b/src/network/kernel/qnetworkproxy_win.cpp index 40abafec73..513eeaac12 100644 --- a/src/network/kernel/qnetworkproxy_win.cpp +++ b/src/network/kernel/qnetworkproxy_win.cpp @@ -323,7 +323,7 @@ static QList parseServerList(const QNetworkProxyQuery &query, con pos = entry.indexOf(QLatin1Char(':'), server); if (pos != -1) { bool ok; - uint value = entry.mid(pos + 1).toUInt(&ok); + uint value = entry.midRef(pos + 1).toUInt(&ok); if (!ok || value > 65535) continue; // invalid port number -- cgit v1.2.3