From 9d504e1150e4bd49d34aba5cee938d1fd9f7e80c Mon Sep 17 00:00:00 2001 From: Albert Astals Cid Date: Fri, 11 Oct 2019 17:31:22 +0200 Subject: QSqlTableModel::record: Use the const & we're given QSqlTableModelPrivate::ModifiedRow::rec returns a const & so use it instead doing a copy. QSqlRecord is cheap to copy constructor but not having to do it is faster Change-Id: Iad6e79fcdcdf380ce681fe9426436f8cb98be553 Reviewed-by: Andy Shaw --- src/sql/models/qsqltablemodel.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sql/models/qsqltablemodel.cpp b/src/sql/models/qsqltablemodel.cpp index 4bc9a8c2f8..ba8a6dea36 100644 --- a/src/sql/models/qsqltablemodel.cpp +++ b/src/sql/models/qsqltablemodel.cpp @@ -1369,7 +1369,7 @@ QSqlRecord QSqlTableModel::record(int row) const // get generated flags from the cache const QSqlTableModelPrivate::ModifiedRow mrow = d->cache.value(row); if (mrow.op() != QSqlTableModelPrivate::None) { - const QSqlRecord crec = mrow.rec(); + const QSqlRecord &crec = mrow.rec(); for (int i = 0, cnt = rec.count(); i < cnt; ++i) rec.setGenerated(i, crec.isGenerated(i)); } -- cgit v1.2.3