From b1ec50c96df0fcfbcf18281ca5d7e1e52dbca5f6 Mon Sep 17 00:00:00 2001 From: Giuseppe D'Angelo Date: Mon, 29 Jun 2020 13:22:30 +0200 Subject: QByteArray::insert: do not assert that pos must be non-negative The insert() overloads have generally a very wide contract. The very next line accepts negative positions, so remove the related assert. Change-Id: I89b67615c59287825942047a28572bf896cf30e3 Reviewed-by: Thiago Macieira --- src/corelib/text/qbytearray.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/corelib/text/qbytearray.cpp b/src/corelib/text/qbytearray.cpp index 2b46bf734d..77f4110601 100644 --- a/src/corelib/text/qbytearray.cpp +++ b/src/corelib/text/qbytearray.cpp @@ -1911,8 +1911,6 @@ QByteArray& QByteArray::append(char ch) static inline QByteArray &qbytearray_insert(QByteArray *ba, int pos, const char *arr, int len) { - Q_ASSERT(pos >= 0); - if (pos < 0 || len <= 0 || arr == nullptr) return *ba; -- cgit v1.2.3