From c5a79d6dbc563719cfc71a2169cfa01156e10307 Mon Sep 17 00:00:00 2001 From: Alex Trotsenko Date: Thu, 9 Sep 2021 17:14:07 +0300 Subject: Allow destruction of QWinEventNotifier in its signal Avoid use-after-free issue in QProcess. Fixes: QTBUG-96285 Fixes: QTBUG-96359 Change-Id: I953d7a8ecaf301ec3a27db37e13748f905c3d097 Reviewed-by: Christoph Cullmann Reviewed-by: Thiago Macieira Reviewed-by: Oswald Buddenhagen (cherry picked from commit 4e0082a9cacfdfd0c43e6105274bc0d41dd18801) --- src/corelib/kernel/qwineventnotifier.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/corelib/kernel/qwineventnotifier.cpp b/src/corelib/kernel/qwineventnotifier.cpp index f9e91e73d7..486e07b649 100644 --- a/src/corelib/kernel/qwineventnotifier.cpp +++ b/src/corelib/kernel/qwineventnotifier.cpp @@ -41,6 +41,7 @@ #include "qcoreapplication.h" #include "qthread.h" +#include QT_BEGIN_NAMESPACE @@ -228,9 +229,10 @@ bool QWinEventNotifier::event(QEvent * e) == QWinEventNotifierPrivate::Posted && d->enabled) { d->unregisterWaitObject(); + QPointer alive(this); emit activated(d->handleToEvent, QPrivateSignal()); - if (d->enabled && d->waitHandle == NULL) + if (alive && d->enabled && d->waitHandle == NULL) d->registerWaitObject(); } return true; -- cgit v1.2.3