From e142a64a33a54c433a38d330d64292b7e7698c92 Mon Sep 17 00:00:00 2001 From: Jo Asplin Date: Thu, 3 Nov 2011 13:16:50 +0100 Subject: Re-enabled passing tests in tst_qvariant To increase the effective test coverage, this patch re-enables the tst_qvariant test case as such, and instead disables only the test functions that are currently failing in CI. Task-number: QTBUG-22453 Change-Id: Ibf0dc3caf50d34084fa50cf76d199e77a42f6e16 Reviewed-by: Olivier Goffart --- tests/auto/corelib/kernel/qvariant/qvariant.pro | 2 -- tests/auto/corelib/kernel/qvariant/tst_qvariant.cpp | 3 +++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/auto/corelib/kernel/qvariant/qvariant.pro b/tests/auto/corelib/kernel/qvariant/qvariant.pro index e81e4d7ce0..7d9cfc288f 100644 --- a/tests/auto/corelib/kernel/qvariant/qvariant.pro +++ b/tests/auto/corelib/kernel/qvariant/qvariant.pro @@ -2,5 +2,3 @@ CONFIG += testcase TARGET = tst_qvariant SOURCES += tst_qvariant.cpp QT += widgets network testlib - -CONFIG+=insignificant_test # See QTBUG-8959 diff --git a/tests/auto/corelib/kernel/qvariant/tst_qvariant.cpp b/tests/auto/corelib/kernel/qvariant/tst_qvariant.cpp index f126151a4c..b3e4777e1b 100644 --- a/tests/auto/corelib/kernel/qvariant/tst_qvariant.cpp +++ b/tests/auto/corelib/kernel/qvariant/tst_qvariant.cpp @@ -2914,6 +2914,9 @@ void tst_QVariant::task256984_setValue() void tst_QVariant::numericalConvert() { +#if defined(Q_OS_LINUX) && defined(Q_CC_GNU) && !defined(__x86_64__) + QSKIP("Known to fail due to a GCC bug on at least Ubuntu 10.04 32-bit - check QTBUG-8959"); +#endif QVariant vfloat(float(5.3)); QVariant vdouble(double(5.3)); QVariant vreal(qreal(5.3)); -- cgit v1.2.3