From e77b13621f0057374d83a2b884f03dd2e5b7b88c Mon Sep 17 00:00:00 2001 From: Louai Al-Khanji Date: Wed, 2 Dec 2015 10:53:37 -0800 Subject: Blitter Paint Engine: Check more specifically for solid fill brush The previous state did not account for Qt::NoBrush. This caused a bug where a draw call with Qt::NoPen and Qt::NoBrush incorrectly causes a solid black fill instead of being a no-op. Change-Id: If3b90d6cb99043d68976aca143cac64ad5d8ea9e Reviewed-by: Laszlo Agocs --- src/gui/painting/qpaintengine_blitter.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gui/painting/qpaintengine_blitter.cpp b/src/gui/painting/qpaintengine_blitter.cpp index ba4481fefd..a50d1dfd73 100644 --- a/src/gui/painting/qpaintengine_blitter.cpp +++ b/src/gui/painting/qpaintengine_blitter.cpp @@ -312,7 +312,7 @@ void QBlitterPaintEnginePrivate::updateBrushState(QPainterState *s) { Qt::BrushStyle style = qbrush_style(s->brush); - caps.updateState(STATE_BRUSH_PATTERN, style > Qt::SolidPattern); + caps.updateState(STATE_BRUSH_PATTERN, style != Qt::SolidPattern); caps.updateState(STATE_BRUSH_ALPHA, qbrush_color(s->brush).alpha() < 255); } -- cgit v1.2.3