From e82c7a8abf28d82d9f36b83c33a3e73a3035cdcc Mon Sep 17 00:00:00 2001 From: Thiago Macieira Date: Fri, 30 Aug 2013 17:14:40 -0700 Subject: Give QWindowsNativeFileDialogEventHandler a virtual destructor GCC complains about this class having virtuals and no virtual destructor. C:/Qt/qt5/qtbase/src/plugins/platforms/windows/qwindowsdialoghelpers.cpp:750:20: warning: deleting object of polymorphic class type 'QWindowsNativeFileDialogEventHandler' which has non-virtual destructor might cause undefined behaviour [-Wdelete-non-virtual-dtor] Change-Id: I7494fce4bb71ed65954226259fa65fdc507ca403 Reviewed-by: Friedemann Kleint Reviewed-by: Kai Koehne --- src/plugins/platforms/windows/qwindowsdialoghelpers.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/platforms/windows/qwindowsdialoghelpers.cpp b/src/plugins/platforms/windows/qwindowsdialoghelpers.cpp index 328842677f..c09f9d22e4 100644 --- a/src/plugins/platforms/windows/qwindowsdialoghelpers.cpp +++ b/src/plugins/platforms/windows/qwindowsdialoghelpers.cpp @@ -763,7 +763,7 @@ public: QWindowsNativeFileDialogEventHandler(QWindowsNativeFileDialogBase *nativeFileDialog) : m_ref(1), m_nativeFileDialog(nativeFileDialog) {} - ~QWindowsNativeFileDialogEventHandler() {} + virtual ~QWindowsNativeFileDialogEventHandler() {} private: long m_ref; -- cgit v1.2.3