From 6d376ea5f409dcef54099b796dc5bc835fa51b7d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tor=20Arne=20Vestb=C3=B8?= Date: Wed, 24 Jun 2020 18:19:15 +0200 Subject: cmake: Apply symbol visibility settings to Objective-C/C++ sources Otherwise the Objective-C++ sources will be built with the default compiler visibility (visible), and then linked with moc-generated C++ sources that have the Qt overridden hidden visibility, resulting in linker warnings such as: ld: warning: direct access in function 'X' from file 'moc_foo.cpp.o' to global weak symbol 'Y' from file 'bar.mm.o' means the weak symbol cannot be overridden at runtime. This was likely caused by different translation units being compiled with different visibility setting Change-Id: I22e15e7e181a74de8c0a22c73d06e600e582d7fd Reviewed-by: Alexandru Croitor --- cmake/QtBuild.cmake | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'cmake/QtBuild.cmake') diff --git a/cmake/QtBuild.cmake b/cmake/QtBuild.cmake index f8bc709637..d99b2145c2 100644 --- a/cmake/QtBuild.cmake +++ b/cmake/QtBuild.cmake @@ -2087,6 +2087,8 @@ function(qt_set_symbol_visibility_preset target value) set_target_properties("${target}" PROPERTIES C_VISIBILITY_PRESET "${value}") set_target_properties("${target}" PROPERTIES CXX_VISIBILITY_PRESET "${value}") + set_target_properties("${target}" PROPERTIES OBJC_VISIBILITY_PRESET "${value}") + set_target_properties("${target}" PROPERTIES OBJCXX_VISIBILITY_PRESET "${value}") endfunction() function(qt_set_symbol_visibility_hidden target) @@ -4150,6 +4152,8 @@ function(qt_add_cmake_library target) add_library("${target}" MODULE) set_property(TARGET ${name} PROPERTY C_VISIBILITY_PRESET default) set_property(TARGET ${name} PROPERTY CXX_VISIBILITY_PRESET default) + set_property(TARGET ${name} PROPERTY OBJC_VISIBILITY_PRESET default) + set_property(TARGET ${name} PROPERTY OBJCXX_VISIBILITY_PRESET default) if(APPLE) # CMake defaults to using .so extensions for loadable modules, aka plugins, @@ -4233,6 +4237,8 @@ function(qt_add_3rdparty_library target) add_library("${target}" MODULE) set_property(TARGET ${name} PROPERTY C_VISIBILITY_PRESET default) set_property(TARGET ${name} PROPERTY CXX_VISIBILITY_PRESET default) + set_property(TARGET ${name} PROPERTY OBJC_VISIBILITY_PRESET default) + set_property(TARGET ${name} PROPERTY OBJCXX_VISIBILITY_PRESET default) if(APPLE) # CMake defaults to using .so extensions for loadable modules, aka plugins, -- cgit v1.2.3