From 278368b523e974665b60d22a0eaf27d9ed130078 Mon Sep 17 00:00:00 2001 From: Joerg Bornemann Date: Mon, 23 Aug 2021 21:12:36 +0200 Subject: CMake: Fix excessive size of precompiled header files Do not add catch-all header files like QtCore, QtGui, etc. to precompiled headers for targets that already define their own set of precompiled header files. This reduces the size of the precompiled headers and brings the pch file sizes down into the region of the qmake build. Pick-to: 6.2 Task-number: QTBUG-89122 Change-Id: I8e4d17aa6829c7d7b1aa01a01a61b6677e22c460 Reviewed-by: Alexey Edelev Reviewed-by: Alexandru Croitor --- cmake/QtTargetHelpers.cmake | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'cmake/QtTargetHelpers.cmake') diff --git a/cmake/QtTargetHelpers.cmake b/cmake/QtTargetHelpers.cmake index baee28ee1e..f497d55924 100644 --- a/cmake/QtTargetHelpers.cmake +++ b/cmake/QtTargetHelpers.cmake @@ -38,9 +38,9 @@ function(qt_internal_extend_target target) set(is_library TRUE) endif() foreach(lib ${arg_PUBLIC_LIBRARIES} ${arg_LIBRARIES}) - # Automatically generate PCH for 'target' using dependencies - # if 'target' is a library/module! - if (${is_library}) + # Automatically generate PCH for 'target' using public dependencies. + # But only if 'target' is a library/module that does not specify its own PCH file. + if(NOT arg_PRECOMPILED_HEADER AND ${is_library}) qt_update_precompiled_header_with_library("${target}" "${lib}") endif() -- cgit v1.2.3