From 0a23cab457ac3a43afb048844fb586eb60a3f88a Mon Sep 17 00:00:00 2001 From: Li Xinwei <1326710505@qq.com> Date: Thu, 3 Dec 2020 23:24:18 +0800 Subject: CMake: Avoid MSVC C4996 warnings The qmake build system defines _CRT_SECURE_NO_WARNINGS in mkspecs/features/qt_module.prf, the cmake build system should do the same thing in qt_internal_add_module(). Adding this definition can avoid warnings like: warning C4996: 'strncpy': This function or variable may be unsafe. As a special case, Bootstrap uses add_library() instead of qt_internal_add_module(), so _CRT_SECURE_NO_WARNINGS should also be defined in src/tools/bootstrap/CMakeLists.txt. Change-Id: Ic82193d177f82785fd84948efa78c49ca8d8db46 Reviewed-by: Alexandru Croitor (cherry picked from commit 013abe320680b3dcd3f6d7e4fb4880e590ba10e6) Reviewed-by: Qt Cherry-pick Bot --- cmake/QtModuleHelpers.cmake | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'cmake') diff --git a/cmake/QtModuleHelpers.cmake b/cmake/QtModuleHelpers.cmake index 1a482ff81b..2c03917f32 100644 --- a/cmake/QtModuleHelpers.cmake +++ b/cmake/QtModuleHelpers.cmake @@ -341,6 +341,10 @@ function(qt_internal_add_module target) ) endif() + if(MSVC) + list(APPEND defines_for_extend_target _CRT_SECURE_NO_WARNINGS) + endif() + qt_internal_extend_target("${target}" ${header_module} SOURCES ${arg_SOURCES} -- cgit v1.2.3