From 419db858f5bf73ff59d3c886003727eb7cab8400 Mon Sep 17 00:00:00 2001 From: Alexandru Croitor Date: Mon, 19 Oct 2020 19:34:17 +0200 Subject: CMake: Fix deprecation defines not being set properly Instead of propagating the deprecation wranings, we compiled all code with -Ddeprecations. Change-Id: I0233ddc85bdbdcb93d366073b2cea5d47bdbe52a Reviewed-by: Qt CI Bot Reviewed-by: Cristian Adam --- cmake/QtFlagHandlingHelpers.cmake | 2 +- cmake/QtModuleHelpers.cmake | 2 +- cmake/QtPluginHelpers.cmake | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) (limited to 'cmake') diff --git a/cmake/QtFlagHandlingHelpers.cmake b/cmake/QtFlagHandlingHelpers.cmake index 8b2677aa3d..685c1616b7 100644 --- a/cmake/QtFlagHandlingHelpers.cmake +++ b/cmake/QtFlagHandlingHelpers.cmake @@ -142,7 +142,7 @@ function(qt_internal_library_deprecation_level result) list(APPEND deprecations "QT_DISABLE_DEPRECATED_BEFORE=0x050000") endif() list(APPEND deprecations "QT_DEPRECATED_WARNINGS_SINCE=0x060000") - set("${result}" deprecations PARENT_SCOPE) + set("${result}" "${deprecations}" PARENT_SCOPE) endfunction() # Sets the exceptions flags for the given target diff --git a/cmake/QtModuleHelpers.cmake b/cmake/QtModuleHelpers.cmake index 9f32a1309a..6431bba589 100644 --- a/cmake/QtModuleHelpers.cmake +++ b/cmake/QtModuleHelpers.cmake @@ -331,7 +331,7 @@ function(qt_internal_add_module target) QT_DEPRECATED_WARNINGS QT_BUILDING_QT QT_BUILD_${module_define}_LIB ### FIXME: use QT_BUILD_ADDON for Add-ons or remove if we don't have add-ons anymore - "${deprecation_define}" + ${deprecation_define} ) endif() diff --git a/cmake/QtPluginHelpers.cmake b/cmake/QtPluginHelpers.cmake index 2591705a9e..6b362b5017 100644 --- a/cmake/QtPluginHelpers.cmake +++ b/cmake/QtPluginHelpers.cmake @@ -174,7 +174,7 @@ function(qt_internal_add_plugin target) DEFINES ${arg_DEFINES} QT_DEPRECATED_WARNINGS - "${deprecation_define}" + ${deprecation_define} "${static_plugin_define}" QT_PLUGIN PUBLIC_DEFINES -- cgit v1.2.3