From 81d15e059fe2367788b3b0d1aa34171a2cc9692b Mon Sep 17 00:00:00 2001 From: Rohan McGovern Date: Wed, 10 Aug 2011 11:49:46 +1000 Subject: configure: fixed debug-and-release default for qpa on mac debug/release is always supposed to default on for platforms where debug/release affects linkage (i.e. mac and windows). Previously, it did not correctly default on for qpa mac builds. Change-Id: I8d3c418f3fb787136ab120872fdd4d2ebf82c90e Reviewed-on: http://codereview.qt.nokia.com/2796 Reviewed-by: Qt Sanity Bot Reviewed-by: Toby Tomkins --- configure | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-) (limited to 'configure') diff --git a/configure b/configure index 877b13eb96..28e3d3aab0 100755 --- a/configure +++ b/configure @@ -2510,23 +2510,6 @@ if [ "$PLATFORM_X11" = "yes" -o "$PLATFORM_QWS" = "yes" -o "$PLATFORM_QPA" = "ye echo fi -# detect build style -if [ "$CFG_DEBUG" = "auto" ]; then - if [ "$PLATFORM_MAC" = "yes" -o "$XPLATFORM_MINGW" = "yes" ]; then - CFG_DEBUG_RELEASE=yes - CFG_DEBUG=yes - elif [ "$CFG_DEV" = "yes" ]; then - CFG_DEBUG_RELEASE=no - CFG_DEBUG=yes - else - CFG_DEBUG_RELEASE=no - CFG_DEBUG=no - fi -fi -if [ "$CFG_DEBUG_RELEASE" = "yes" ]; then - QMAKE_CONFIG="$QMAKE_CONFIG build_all" -fi - if [ "$CFG_SILENT" = "yes" ]; then QMAKE_CONFIG="$QMAKE_CONFIG silent" fi @@ -3243,6 +3226,23 @@ fi # tests that don't need qmake (must be run before displaying help) #------------------------------------------------------------------------------- +# detect build style +if [ "$CFG_DEBUG" = "auto" ]; then + if [ "$CFG_ARCH" = "macosx" -o "$XPLATFORM_MINGW" = "yes" ]; then + CFG_DEBUG_RELEASE=yes + CFG_DEBUG=yes + elif [ "$CFG_DEV" = "yes" ]; then + CFG_DEBUG_RELEASE=no + CFG_DEBUG=yes + else + CFG_DEBUG_RELEASE=no + CFG_DEBUG=no + fi +fi +if [ "$CFG_DEBUG_RELEASE" = "yes" ]; then + QMAKE_CONFIG="$QMAKE_CONFIG build_all" +fi + if [ -z "$PKG_CONFIG" ]; then # See if PKG_CONFIG is set in the mkspec: PKG_CONFIG=`getQMakeConf "$XQMAKESPEC" | sed -n -e 's%PKG_CONFIG[^_].*=%%p' | tr '\n' ' '` -- cgit v1.2.3 From 7ebfe33e38a81f2a47bb251e093aeb718dbe34e6 Mon Sep 17 00:00:00 2001 From: Rohan McGovern Date: Thu, 11 Aug 2011 13:14:14 +1000 Subject: configure: fixed usage of rpath on mac This logic should be used for all mac platforms. Currently it is erroneously skipped for qpa on mac. Change-Id: Ibc8e0bb38d4c08f48292639c614bc328c703b1bc Reviewed-on: http://codereview.qt.nokia.com/2836 Reviewed-by: Qt Sanity Bot Reviewed-by: Kalle Lehtonen --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'configure') diff --git a/configure b/configure index 28e3d3aab0..f4691e12c2 100755 --- a/configure +++ b/configure @@ -7311,7 +7311,7 @@ fi [ '!' -z "$L_FLAGS" ] && QMakeVar add QMAKE_LIBDIR_FLAGS "$L_FLAGS" [ '!' -z "$l_FLAGS" ] && QMakeVar add LIBS "$l_FLAGS" -if [ "$PLATFORM_MAC" = "yes" ]; then +if [ "$CFG_ARCH" = "macosx" ]; then if [ "$CFG_RPATH" = "yes" ]; then QMAKE_CONFIG="$QMAKE_CONFIG absolute_library_soname" fi -- cgit v1.2.3 From d6d3a32a688da08fd0eab74c9b142e34a7676d17 Mon Sep 17 00:00:00 2001 From: Kai Koehne Date: Mon, 15 Aug 2011 15:36:08 +0200 Subject: Configure: Set separate_debug_info for all modules separate_debug_info was previously stored in .qmake.cache, and therefore only affected qtbase. Store it as a QT_CONFIG setting instead, and add it to CONFIG for all Qt plugins and modules. Change-Id: I940c8cb30f1c42c85f4d0342e6a482f20677ff04 Reviewed-on: http://codereview.qt.nokia.com/2975 Reviewed-by: Qt Sanity Bot Reviewed-by: Oswald Buddenhagen Reviewed-by: Marius Storm-Olsen --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'configure') diff --git a/configure b/configure index f4691e12c2..0a18aafd8c 100755 --- a/configure +++ b/configure @@ -7113,10 +7113,10 @@ fi if [ "$CFG_SEPARATE_DEBUG_INFO" = "yes" ]; then QMakeVar add QMAKE_CFLAGS -g QMakeVar add QMAKE_CXXFLAGS -g - QMAKE_CONFIG="$QMAKE_CONFIG separate_debug_info" + QT_CONFIG="$QT_CONFIG separate_debug_info" fi if [ "$CFG_SEPARATE_DEBUG_INFO_NOCOPY" = "yes" ] ; then - QMAKE_CONFIG="$QMAKE_CONFIG separate_debug_info_nocopy" + QT_CONFIG="$QT_CONFIG separate_debug_info_nocopy" fi [ "$CFG_MMX" = "yes" ] && QMAKE_CONFIG="$QMAKE_CONFIG mmx" [ "$CFG_3DNOW" = "yes" ] && QMAKE_CONFIG="$QMAKE_CONFIG 3dnow" -- cgit v1.2.3