From d7e8b57d0a98696a05cfb0eb15236a34301d9d0a Mon Sep 17 00:00:00 2001 From: Sze Howe Koh Date: Fri, 19 Oct 2012 00:33:03 +0800 Subject: Remove the QThread::terminated() signal The signal is removed from the API; all references to it are removed from documentation; the unit test that checks for its emission is modified to listen for QThread::finished() instead. The QThreadPrivate::terminated flag is also removed, as it served no purpose other than to trigger the emission of QThread::terminated() As discussed at http://lists.qt-project.org/pipermail/development/2012-October/007216.html the signal is not guaranteed to be emitted after every termination, rendering it useless. Change-Id: I7b0c45d7889da0d33875545331606f2208ee56fc Reviewed-by: Lars Knoll Reviewed-by: Olivier Goffart --- dist/changes-5.0.0 | 2 ++ 1 file changed, 2 insertions(+) (limited to 'dist') diff --git a/dist/changes-5.0.0 b/dist/changes-5.0.0 index 834b62edbe..5c9d5147c4 100644 --- a/dist/changes-5.0.0 +++ b/dist/changes-5.0.0 @@ -323,6 +323,8 @@ information about a particular change. - QAbstractPageSetupDialog has been removed. +- QThread::terminated() has been removed, since its emission cannot be guaranteed. + **************************************************************************** * General * **************************************************************************** -- cgit v1.2.3