From a779d68256ba2568f47aab9c5efbcef0cf8c277e Mon Sep 17 00:00:00 2001 From: Christian Ehrlicher Date: Sun, 24 Dec 2017 13:22:48 +0100 Subject: MimeTypeBrowser: avoid memleaks MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In MainWindow ctor some member values were allocated without a parent and not cleaned up in dtor. Fixed it by give them a valid parent so they get automatically cleaned up. Also m_treeView was initialized twice. Task-number: QTBUG-61862 Change-Id: I5590b87bb517c55db6eb58e700a5d419c0acdba2 Reviewed-by: Topi Reiniö Reviewed-by: Martin Smith --- examples/corelib/mimetypes/mimetypebrowser/mainwindow.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'examples/corelib/mimetypes') diff --git a/examples/corelib/mimetypes/mimetypebrowser/mainwindow.cpp b/examples/corelib/mimetypes/mimetypebrowser/mainwindow.cpp index 1d36b7e5ef..bc7ec17d1c 100644 --- a/examples/corelib/mimetypes/mimetypebrowser/mainwindow.cpp +++ b/examples/corelib/mimetypes/mimetypebrowser/mainwindow.cpp @@ -72,8 +72,8 @@ MainWindow::MainWindow(QWidget *parent) : QMainWindow(parent) , m_model(new MimetypeModel(this)) - , m_treeView(new QTreeView) - , m_detailsText(new QTextEdit) + , m_treeView(new QTreeView(this)) + , m_detailsText(new QTextEdit(this)) , m_findIndex(0) { setWindowTitle(tr("Qt Mime Database Browser")); @@ -97,9 +97,8 @@ MainWindow::MainWindow(QWidget *parent) menuBar()->addMenu(tr("&About"))->addAction(tr("&About Qt"), qApp, &QApplication::aboutQt); - QSplitter *centralSplitter = new QSplitter; + QSplitter *centralSplitter = new QSplitter(this); setCentralWidget(centralSplitter); - m_treeView = new QTreeView; m_treeView->setUniformRowHeights(true); m_treeView->setModel(m_model); -- cgit v1.2.3