From 0908175a1aafe9131c501c3a653ba7621e701f80 Mon Sep 17 00:00:00 2001 From: Timur Pocheptsov Date: Thu, 10 Dec 2020 11:11:23 +0100 Subject: secureudpclient - a speculative fix for non-reproducible crash MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Not much information in a bug report: QByteArray is protected from negative sizes and QUdpSocket too. FWIW - add one more check, similar to what the server counterpart already had. Fixes: QTBUG-83457 Change-Id: I585fa90e0a258d2257e4fed2f24c52b47548bcbb Reviewed-by: Mårten Nordheim (cherry picked from commit b283ce1e836ab08e602a11ea255ee3d8e537902e) Reviewed-by: Qt Cherry-pick Bot --- examples/network/secureudpclient/association.cpp | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'examples/network') diff --git a/examples/network/secureudpclient/association.cpp b/examples/network/secureudpclient/association.cpp index c950260078..59df94d5b9 100644 --- a/examples/network/secureudpclient/association.cpp +++ b/examples/network/secureudpclient/association.cpp @@ -112,6 +112,11 @@ void DtlsAssociation::udpSocketConnected() void DtlsAssociation::readyRead() { + if (socket.pendingDatagramSize() <= 0) { + emit warningMessage(tr("%1: spurious read notification?").arg(name)); + return; + } + //! [6] QByteArray dgram(socket.pendingDatagramSize(), Qt::Uninitialized); const qint64 bytesRead = socket.readDatagram(dgram.data(), dgram.size()); -- cgit v1.2.3