From 3b0c2b7c1b3ccdfe6867884a7e210bfc63e10f84 Mon Sep 17 00:00:00 2001 From: Olivier Goffart Date: Mon, 14 Jul 2014 09:13:02 +0200 Subject: Examples: Add Q_DECL_OVERRIDE to overridden functions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Q_DECL_OVERRIDE (which expands to 'override' for supported compiler) helps to declare the intent (that it is an overridden function) and force compilation error when there is no such virtual function in the base class. The examples should show the best practice of having it, as it may save the programmer quite some time in case of change of API or typo in the function name or arguments. This change was done automatically with clang-modernize -add-override -override-macros And fixed MSVC compilation by removing inline for TorrentViewDelegate::paint Change-Id: Ice66ae93fae571266f908703d5b8892b2c1ebb1a Reviewed-by: Jędrzej Nowacki --- examples/widgets/statemachine/rogue/movementtransition.h | 4 ++-- examples/widgets/statemachine/rogue/window.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) (limited to 'examples/widgets/statemachine/rogue') diff --git a/examples/widgets/statemachine/rogue/movementtransition.h b/examples/widgets/statemachine/rogue/movementtransition.h index 23359f7886..5cfa868b22 100644 --- a/examples/widgets/statemachine/rogue/movementtransition.h +++ b/examples/widgets/statemachine/rogue/movementtransition.h @@ -59,7 +59,7 @@ public: //![1] protected: - bool eventTest(QEvent *event) { + bool eventTest(QEvent *event) Q_DECL_OVERRIDE { if (event->type() == QEvent::StateMachineWrapped && static_cast(event)->event()->type() == QEvent::KeyPress) { QEvent *wrappedEvent = static_cast(event)->event(); @@ -76,7 +76,7 @@ protected: //![1] //![2] - void onTransition(QEvent *event) { + void onTransition(QEvent *event) Q_DECL_OVERRIDE { QKeyEvent *keyEvent = static_cast( static_cast(event)->event()); diff --git a/examples/widgets/statemachine/rogue/window.h b/examples/widgets/statemachine/rogue/window.h index 71f195cba1..482c8cf111 100644 --- a/examples/widgets/statemachine/rogue/window.h +++ b/examples/widgets/statemachine/rogue/window.h @@ -67,10 +67,10 @@ public: void setStatus(const QString &status); QString status() const; - QSize sizeHint() const; + QSize sizeHint() const Q_DECL_OVERRIDE; protected: - void paintEvent(QPaintEvent *event); + void paintEvent(QPaintEvent *event) Q_DECL_OVERRIDE; //![0] //![1] -- cgit v1.2.3