From 3c74720f74baa05f19863d7d3310b4d9fe1d2206 Mon Sep 17 00:00:00 2001 From: "Bradley T. Hughes" Date: Tue, 8 Nov 2011 18:03:57 +0100 Subject: Assign function argument to class member, not to itself The 'worker' function argument shadows the class member of the same name, and 'worker = worker;' assigns the function argument to itself, not to the member as intended. examples/tutorials/threads/movedobject/thread.cpp:69: warning: explicitly assigning a variable of type 'QObject *' to itself [-Wself- worker = worker; ~~~~~~ ^ ~~~~~~ Change-Id: If4adf486a86a4ba4e7f7040a7771a70b7dd9aa86 Reviewed-by: Olivier Goffart --- examples/tutorials/threads/movedobject/thread.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'examples') diff --git a/examples/tutorials/threads/movedobject/thread.cpp b/examples/tutorials/threads/movedobject/thread.cpp index d8a17eefe6..5ebd873482 100644 --- a/examples/tutorials/threads/movedobject/thread.cpp +++ b/examples/tutorials/threads/movedobject/thread.cpp @@ -66,7 +66,7 @@ Thread::~Thread() // starts thread, moves worker to this thread and blocks void Thread::launchWorker(QObject *worker) { - worker = worker; + this->worker = worker; start(); worker->moveToThread(this); shutDownHelper->moveToThread(this); -- cgit v1.2.3