From 43325a23f35bce7eddfb2e74d2a65d381b1c6aa0 Mon Sep 17 00:00:00 2001 From: Stephen Kelly Date: Fri, 28 Sep 2012 17:22:21 +0200 Subject: Delete the QVariant ctors taking global Qt enum values. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit They have unexpected results in Qt 5 (the Qt::GlobalColor one works as expected in Qt 4, but was removed in Qt 5): QVariant v = QVariant(Qt::red); qDebug() << v; // QVariant(int, 7) v = Qt::red; qDebug() << v; // QVariant(int, 7) The correct way is to use: QVariant v = QVariant::fromValue(QColor(Qt::red)); The deleted constructors are the ones for which there is a class with an implicit constructor taking the enum, and that class is a built-in metatype. QLocale::Language and QKeySequence::StandardKey would also fit the description, but I can't include the header for QKeySequence as it is in QtGui, and I don't want to include the qlocale header in qvariant.h. Putting a QLocale::Language is probably very uncommon anyway. The QTextFormat test is doing the wrong thing, but the result isn't being tested. Added new tests which fail before the patch. Change-Id: Ia38a0784990f4d40ff7457a86daf58aabd4964eb Reviewed-by: Jędrzej Nowacki --- examples/widgets/animation/stickman/lifecycle.cpp | 12 +++--- examples/widgets/painting/basicdrawing/window.cpp | 50 +++++++++++------------ 2 files changed, 31 insertions(+), 31 deletions(-) (limited to 'examples') diff --git a/examples/widgets/animation/stickman/lifecycle.cpp b/examples/widgets/animation/stickman/lifecycle.cpp index d09d110118..09dec07dfe 100644 --- a/examples/widgets/animation/stickman/lifecycle.cpp +++ b/examples/widgets/animation/stickman/lifecycle.cpp @@ -114,9 +114,9 @@ LifeCycle::LifeCycle(StickMan *stickMan, GraphicsView *keyReceiver) // Make it blink when lightning strikes before entering dead animation QState *lightningBlink = new QState(m_machine); - lightningBlink->assignProperty(m_stickMan->scene(), "backgroundBrush", Qt::white); - lightningBlink->assignProperty(m_stickMan, "penColor", Qt::black); - lightningBlink->assignProperty(m_stickMan, "fillColor", Qt::white); + lightningBlink->assignProperty(m_stickMan->scene(), "backgroundBrush", QColor(Qt::white)); + lightningBlink->assignProperty(m_stickMan, "penColor", QColor(Qt::black)); + lightningBlink->assignProperty(m_stickMan, "fillColor", QColor(Qt::white)); lightningBlink->assignProperty(m_stickMan, "isDead", true); //! [5] @@ -128,9 +128,9 @@ LifeCycle::LifeCycle(StickMan *stickMan, GraphicsView *keyReceiver) //! [5] m_dead = new QState(m_machine); - m_dead->assignProperty(m_stickMan->scene(), "backgroundBrush", Qt::black); - m_dead->assignProperty(m_stickMan, "penColor", Qt::white); - m_dead->assignProperty(m_stickMan, "fillColor", Qt::black); + m_dead->assignProperty(m_stickMan->scene(), "backgroundBrush", QColor(Qt::black)); + m_dead->assignProperty(m_stickMan, "penColor", QColor(Qt::white)); + m_dead->assignProperty(m_stickMan, "fillColor", QColor(Qt::black)); m_dead->setObjectName("dead"); // Idle state (sets no properties) diff --git a/examples/widgets/painting/basicdrawing/window.cpp b/examples/widgets/painting/basicdrawing/window.cpp index 9136c36f93..bf01e57b7f 100644 --- a/examples/widgets/painting/basicdrawing/window.cpp +++ b/examples/widgets/painting/basicdrawing/window.cpp @@ -82,12 +82,12 @@ Window::Window() //! [3] penStyleComboBox = new QComboBox; - penStyleComboBox->addItem(tr("Solid"), Qt::SolidLine); - penStyleComboBox->addItem(tr("Dash"), Qt::DashLine); - penStyleComboBox->addItem(tr("Dot"), Qt::DotLine); - penStyleComboBox->addItem(tr("Dash Dot"), Qt::DashDotLine); - penStyleComboBox->addItem(tr("Dash Dot Dot"), Qt::DashDotDotLine); - penStyleComboBox->addItem(tr("None"), Qt::NoPen); + penStyleComboBox->addItem(tr("Solid"), static_cast(Qt::SolidLine)); + penStyleComboBox->addItem(tr("Dash"), static_cast(Qt::DashLine)); + penStyleComboBox->addItem(tr("Dot"), static_cast(Qt::DotLine)); + penStyleComboBox->addItem(tr("Dash Dot"), static_cast(Qt::DashDotLine)); + penStyleComboBox->addItem(tr("Dash Dot Dot"), static_cast(Qt::DashDotDotLine)); + penStyleComboBox->addItem(tr("None"), static_cast(Qt::NoPen)); penStyleLabel = new QLabel(tr("&Pen Style:")); penStyleLabel->setBuddy(penStyleComboBox); @@ -112,27 +112,27 @@ Window::Window() //! [4] brushStyleComboBox = new QComboBox; brushStyleComboBox->addItem(tr("Linear Gradient"), - Qt::LinearGradientPattern); + static_cast(Qt::LinearGradientPattern)); brushStyleComboBox->addItem(tr("Radial Gradient"), - Qt::RadialGradientPattern); + static_cast(Qt::RadialGradientPattern)); brushStyleComboBox->addItem(tr("Conical Gradient"), - Qt::ConicalGradientPattern); - brushStyleComboBox->addItem(tr("Texture"), Qt::TexturePattern); - brushStyleComboBox->addItem(tr("Solid"), Qt::SolidPattern); - brushStyleComboBox->addItem(tr("Horizontal"), Qt::HorPattern); - brushStyleComboBox->addItem(tr("Vertical"), Qt::VerPattern); - brushStyleComboBox->addItem(tr("Cross"), Qt::CrossPattern); - brushStyleComboBox->addItem(tr("Backward Diagonal"), Qt::BDiagPattern); - brushStyleComboBox->addItem(tr("Forward Diagonal"), Qt::FDiagPattern); - brushStyleComboBox->addItem(tr("Diagonal Cross"), Qt::DiagCrossPattern); - brushStyleComboBox->addItem(tr("Dense 1"), Qt::Dense1Pattern); - brushStyleComboBox->addItem(tr("Dense 2"), Qt::Dense2Pattern); - brushStyleComboBox->addItem(tr("Dense 3"), Qt::Dense3Pattern); - brushStyleComboBox->addItem(tr("Dense 4"), Qt::Dense4Pattern); - brushStyleComboBox->addItem(tr("Dense 5"), Qt::Dense5Pattern); - brushStyleComboBox->addItem(tr("Dense 6"), Qt::Dense6Pattern); - brushStyleComboBox->addItem(tr("Dense 7"), Qt::Dense7Pattern); - brushStyleComboBox->addItem(tr("None"), Qt::NoBrush); + static_cast(Qt::ConicalGradientPattern)); + brushStyleComboBox->addItem(tr("Texture"), static_cast(Qt::TexturePattern)); + brushStyleComboBox->addItem(tr("Solid"), static_cast(Qt::SolidPattern)); + brushStyleComboBox->addItem(tr("Horizontal"), static_cast(Qt::HorPattern)); + brushStyleComboBox->addItem(tr("Vertical"), static_cast(Qt::VerPattern)); + brushStyleComboBox->addItem(tr("Cross"), static_cast(Qt::CrossPattern)); + brushStyleComboBox->addItem(tr("Backward Diagonal"), static_cast(Qt::BDiagPattern)); + brushStyleComboBox->addItem(tr("Forward Diagonal"), static_cast(Qt::FDiagPattern)); + brushStyleComboBox->addItem(tr("Diagonal Cross"), static_cast(Qt::DiagCrossPattern)); + brushStyleComboBox->addItem(tr("Dense 1"), static_cast(Qt::Dense1Pattern)); + brushStyleComboBox->addItem(tr("Dense 2"), static_cast(Qt::Dense2Pattern)); + brushStyleComboBox->addItem(tr("Dense 3"), static_cast(Qt::Dense3Pattern)); + brushStyleComboBox->addItem(tr("Dense 4"), static_cast(Qt::Dense4Pattern)); + brushStyleComboBox->addItem(tr("Dense 5"), static_cast(Qt::Dense5Pattern)); + brushStyleComboBox->addItem(tr("Dense 6"), static_cast(Qt::Dense6Pattern)); + brushStyleComboBox->addItem(tr("Dense 7"), static_cast(Qt::Dense7Pattern)); + brushStyleComboBox->addItem(tr("None"), static_cast(Qt::NoBrush)); brushStyleLabel = new QLabel(tr("&Brush:")); brushStyleLabel->setBuddy(brushStyleComboBox); -- cgit v1.2.3