From 9e09677c1dd4da92735736a0fbcb703416bf4d6d Mon Sep 17 00:00:00 2001 From: David Skoland Date: Fri, 8 Jan 2021 12:57:47 +0100 Subject: Remove QtDBus includes Per the discussion of QTBUG-88831, we determined that module-wide imports are unfortunate, especially for compile times. Following this, all QtDBus includes have been replaced with the headers for the classes actually used in each file. Additionally, some cleanup of header file order and format has been performed in the changed files. Pick-to: 6.0 Change-Id: I62c1b75682a48422f0ba1168dd5d7bd0952808ac Reviewed-by: Qt CI Bot Reviewed-by: Volker Hilsheimer Reviewed-by: Edward Welbourne --- examples/dbus/complexpingpong/complexping.cpp | 17 +++++++++-------- examples/dbus/complexpingpong/complexpong.cpp | 15 ++++++++------- examples/dbus/listnames/listnames.cpp | 11 +++++++---- examples/dbus/pingpong/ping.cpp | 10 ++++++---- examples/dbus/pingpong/pong.cpp | 15 ++++++++------- examples/dbus/remotecontrolledcar/controller/main.cpp | 2 +- 6 files changed, 39 insertions(+), 31 deletions(-) (limited to 'examples') diff --git a/examples/dbus/complexpingpong/complexping.cpp b/examples/dbus/complexpingpong/complexping.cpp index cf2535930d..8878083ee9 100644 --- a/examples/dbus/complexpingpong/complexping.cpp +++ b/examples/dbus/complexpingpong/complexping.cpp @@ -48,17 +48,18 @@ ** ****************************************************************************/ -#include - -#include -#include -#include -#include -#include - #include "ping-common.h" #include "complexping.h" +#include +#include +#include +#include +#include +#include + +#include + void Ping::start(const QString &name) { if (name != SERVICE_NAME) diff --git a/examples/dbus/complexpingpong/complexpong.cpp b/examples/dbus/complexpingpong/complexpong.cpp index c9cc78b376..6b3430bc94 100644 --- a/examples/dbus/complexpingpong/complexpong.cpp +++ b/examples/dbus/complexpingpong/complexpong.cpp @@ -48,16 +48,17 @@ ** ****************************************************************************/ -#include -#include - -#include -#include -#include - #include "ping-common.h" #include "complexpong.h" +#include +#include +#include +#include + +#include +#include + // the property QString Pong::value() const { diff --git a/examples/dbus/listnames/listnames.cpp b/examples/dbus/listnames/listnames.cpp index 50203da73d..fcd0e060a4 100644 --- a/examples/dbus/listnames/listnames.cpp +++ b/examples/dbus/listnames/listnames.cpp @@ -48,10 +48,13 @@ ** ****************************************************************************/ -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include +#include void method1() { diff --git a/examples/dbus/pingpong/ping.cpp b/examples/dbus/pingpong/ping.cpp index e013a82eb2..64c1fe6bbf 100644 --- a/examples/dbus/pingpong/ping.cpp +++ b/examples/dbus/pingpong/ping.cpp @@ -48,12 +48,14 @@ ** ****************************************************************************/ -#include +#include "ping-common.h" -#include -#include +#include +#include +#include +#include -#include "ping-common.h" +#include int main(int argc, char **argv) { diff --git a/examples/dbus/pingpong/pong.cpp b/examples/dbus/pingpong/pong.cpp index e1e362f218..37f6261142 100644 --- a/examples/dbus/pingpong/pong.cpp +++ b/examples/dbus/pingpong/pong.cpp @@ -48,16 +48,17 @@ ** ****************************************************************************/ -#include -#include - -#include -#include -#include - #include "ping-common.h" #include "pong.h" +#include +#include +#include +#include + +#include +#include + QString Pong::ping(const QString &arg) { QMetaObject::invokeMethod(QCoreApplication::instance(), "quit"); diff --git a/examples/dbus/remotecontrolledcar/controller/main.cpp b/examples/dbus/remotecontrolledcar/controller/main.cpp index 88edd13c1b..4aeff8635e 100644 --- a/examples/dbus/remotecontrolledcar/controller/main.cpp +++ b/examples/dbus/remotecontrolledcar/controller/main.cpp @@ -49,7 +49,7 @@ ****************************************************************************/ #include -#include + #include "controller.h" -- cgit v1.2.3