From aa30f49d6a38c77693ecf58ea9cbd13470e5fe9c Mon Sep 17 00:00:00 2001 From: Oswald Buddenhagen Date: Thu, 27 Nov 2014 15:02:50 +0100 Subject: prune pointless assignments of QString::replace() and remove() results they operate in-place. Change-Id: Iab6f2f6a9f6f67b9d70feb77ec719e424909022d Reviewed-by: Joerg Bornemann --- qmake/generators/win32/msvc_vcproj.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'qmake/generators/win32/msvc_vcproj.cpp') diff --git a/qmake/generators/win32/msvc_vcproj.cpp b/qmake/generators/win32/msvc_vcproj.cpp index 33d01a41ef..7faab0b1bc 100644 --- a/qmake/generators/win32/msvc_vcproj.cpp +++ b/qmake/generators/win32/msvc_vcproj.cpp @@ -1693,11 +1693,11 @@ QString VcprojGenerator::fixFilename(QString ofile) const ofile = Option::fixPathToLocalOS(ofile); int slashfind = ofile.lastIndexOf(Option::dir_sep); if(slashfind == -1) { - ofile = ofile.replace('-', '_'); + ofile.replace('-', '_'); } else { int hyphenfind = ofile.indexOf('-', slashfind); while (hyphenfind != -1 && slashfind < hyphenfind) { - ofile = ofile.replace(hyphenfind, 1, '_'); + ofile.replace(hyphenfind, 1, '_'); hyphenfind = ofile.indexOf('-', hyphenfind + 1); } } -- cgit v1.2.3