From 7246058dfd7511e5732a6d74521ce4a717c73f70 Mon Sep 17 00:00:00 2001 From: Joerg Bornemann Date: Tue, 4 Jan 2022 14:30:46 +0100 Subject: qmake/MinGW: Fix linking target name with whitespace When having a TARGET value that contains whitespace, linking would fail with MinGW. This was, because the function createResponseFile stitched together a file name like this: objectScript."Target Name".Release The inner double quotes make the file name invalid. Fix this by retrieving QMAKE_ORIG_TARGET with the var() method instead of fileVar(). The latter quotes the return value if it contains spaces. Pick-to: 5.15 6.2 6.3 Fixes: QTBUG-99522 Change-Id: Ieb7dcf3fbbd8a75de5a9b9a6beadb2170dddf35d Reviewed-by: Kai Koehne --- qmake/generators/makefile.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'qmake/generators') diff --git a/qmake/generators/makefile.cpp b/qmake/generators/makefile.cpp index 5a17a92425..53d50f23f9 100644 --- a/qmake/generators/makefile.cpp +++ b/qmake/generators/makefile.cpp @@ -3497,7 +3497,7 @@ QString MakefileGenerator::createResponseFile( const ProStringList &objList, const QString &prefix) { - QString fileName = baseName + '.' + fileVar("QMAKE_ORIG_TARGET"); + QString fileName = baseName + '.' + var("QMAKE_ORIG_TARGET"); if (!var("BUILD_NAME").isEmpty()) fileName += '.' + var("BUILD_NAME"); if (!var("MAKEFILE").isEmpty()) -- cgit v1.2.3