From a7564e2657dcbd2f69c357d7c49c9326a23ee021 Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Mon, 12 Jul 2021 11:15:44 +0200 Subject: QDuplicateTracker: accept the number of elements to reserve as a ctor argument MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This prevents us from first reserve()ing Prealloc elements, and then possibly reserve()ing a larger number, which leaves the first bucket list's memory unused. Consequently, deprecate reserve(). Change-Id: Ifc0a5a021097f4589557e7b5e45d9d0892797ade Reviewed-by: Qt CI Bot Reviewed-by: MÃ¥rten Nordheim --- qmake/library/proitems.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'qmake/library') diff --git a/qmake/library/proitems.cpp b/qmake/library/proitems.cpp index ba817596c5..a8f4dfe039 100644 --- a/qmake/library/proitems.cpp +++ b/qmake/library/proitems.cpp @@ -404,8 +404,7 @@ void ProStringList::removeEmpty() void ProStringList::removeDuplicates() { - QDuplicateTracker seen; - seen.reserve(size()); + QDuplicateTracker seen(size()); removeIf([&](const ProString &s) { return seen.hasSeen(s); }); } -- cgit v1.2.3