From aa30f49d6a38c77693ecf58ea9cbd13470e5fe9c Mon Sep 17 00:00:00 2001 From: Oswald Buddenhagen Date: Thu, 27 Nov 2014 15:02:50 +0100 Subject: prune pointless assignments of QString::replace() and remove() results they operate in-place. Change-Id: Iab6f2f6a9f6f67b9d70feb77ec719e424909022d Reviewed-by: Joerg Bornemann --- qmake/option.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'qmake/option.cpp') diff --git a/qmake/option.cpp b/qmake/option.cpp index cb851229b4..d92f3b7ac2 100644 --- a/qmake/option.cpp +++ b/qmake/option.cpp @@ -530,15 +530,15 @@ Option::fixString(QString string, uchar flags) //fix separators if (flags & Option::FixPathToNormalSeparators) { - string = string.replace('\\', '/'); + string.replace('\\', '/'); } else if (flags & Option::FixPathToLocalSeparators) { #if defined(Q_OS_WIN32) - string = string.replace('/', '\\'); + string.replace('/', '\\'); #else - string = string.replace('\\', '/'); + string.replace('\\', '/'); #endif } else if(flags & Option::FixPathToTargetSeparators) { - string = string.replace('/', Option::dir_sep).replace('\\', Option::dir_sep); + string.replace('/', Option::dir_sep).replace('\\', Option::dir_sep); } if ((string.startsWith("\"") && string.endsWith("\"")) || -- cgit v1.2.3