From 2e18c9af262ac93f192aa09731e98a09e21f18b9 Mon Sep 17 00:00:00 2001 From: Bjoern Breitmeyer Date: Wed, 18 Mar 2015 18:11:44 +0100 Subject: Fix incorrect pass by value. Make sure we don't pass by value, but by const reference. Change-Id: Ia432e881d2b8116f22a30dfa31186479784ee4a1 Reviewed-by: Oswald Buddenhagen --- qmake/generators/win32/cesdkhandler.cpp | 2 +- qmake/generators/win32/cesdkhandler.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'qmake') diff --git a/qmake/generators/win32/cesdkhandler.cpp b/qmake/generators/win32/cesdkhandler.cpp index 1391cb297d..cbee1d0dbd 100644 --- a/qmake/generators/win32/cesdkhandler.cpp +++ b/qmake/generators/win32/cesdkhandler.cpp @@ -350,7 +350,7 @@ bool CeSdkHandler::retrieveAvailableSDKs() return !m_list.empty(); } -QString CeSdkHandler::fixPaths(QString path) const +QString CeSdkHandler::fixPaths(const QString &path) const { QRegExp searchStr(QLatin1String("(\\$\\(\\w+\\))")); QString fixedString = path; diff --git a/qmake/generators/win32/cesdkhandler.h b/qmake/generators/win32/cesdkhandler.h index 522712ff88..b90c3c6dce 100644 --- a/qmake/generators/win32/cesdkhandler.h +++ b/qmake/generators/win32/cesdkhandler.h @@ -76,9 +76,9 @@ public: bool retrieveAvailableSDKs(); inline QList listAll() const { return m_list; } private: - inline QString fixPaths(QString path) const; void retrieveWEC6n7SDKs(); void retrieveWEC2013SDKs(); + inline QString fixPaths(const QString &path) const; QStringList getMsBuildToolPaths() const; QStringList filterMsBuildToolPaths(const QStringList &paths) const; bool parseMsBuildFile(QFile *file, CeSdkInfo *info); -- cgit v1.2.3