From b9835aef1a36688ea99602e25e9c73e645d3851a Mon Sep 17 00:00:00 2001 From: Oswald Buddenhagen Date: Fri, 27 Apr 2018 20:39:37 +0200 Subject: qmake: make even more use QStringRef and QStringView overloads Change-Id: If067368529f89347a4618a24e2737e04b4fc0ce3 Reviewed-by: Joerg Bornemann --- qmake/library/qmakebuiltins.cpp | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'qmake') diff --git a/qmake/library/qmakebuiltins.cpp b/qmake/library/qmakebuiltins.cpp index c1d446263e..856292552e 100644 --- a/qmake/library/qmakebuiltins.cpp +++ b/qmake/library/qmakebuiltins.cpp @@ -1644,9 +1644,8 @@ QMakeEvaluator::VisitReturn QMakeEvaluator::evaluateBuiltinConditional( } for (ProValueMap::ConstIterator it = symbols.constBegin(); it != symbols.constEnd(); ++it) { - const QString &ky = it.key().toQString(m_tmp1); - if (!ky.startsWith(QLatin1Char('.'))) - newMap.insert(ProKey(parseInto + ky), it.value()); + if (!it.key().startsWith(QLatin1Char('.'))) + newMap.insert(ProKey(parseInto + it.key()), it.value()); } m_valuemapStack.top() = newMap; } @@ -1802,7 +1801,7 @@ QMakeEvaluator::VisitReturn QMakeEvaluator::evaluateBuiltinConditional( } else if (opt == QLatin1String("exe")) { flags |= QMakeVfs::VfsExecutable; } else { - evalError(fL1S("write_file(): invalid flag %1.").arg(opt.toQString(m_tmp3))); + evalError(fL1S("write_file(): invalid flag %1.").arg(opt.toQStringView())); return ReturnFalse; } } @@ -1853,7 +1852,7 @@ QMakeEvaluator::VisitReturn QMakeEvaluator::evaluateBuiltinConditional( } else if (opt == QLatin1String("sub")) { mode = CacheSub; } else { - evalError(fL1S("cache(): invalid flag %1.").arg(opt.toQString(m_tmp3))); + evalError(fL1S("cache(): invalid flag %1.").arg(opt.toQStringView())); return ReturnFalse; } } -- cgit v1.2.3