From 8dbd245979dac890c9317a27067a43205314a4f0 Mon Sep 17 00:00:00 2001 From: Christian Ehrlicher Date: Sun, 11 Feb 2018 12:31:04 +0100 Subject: QtConcurrent::MedianDouble: do not access uninitialzed values Properly initialize MedianDouble::values in ctor. This fixes the following valgrind warnings in the unit test: Conditional jump or move depends on uninitialised value(s) at 0x40771E4: addValue (qtconcurrentmedian.h:161) by 0x40771E4: QtConcurrent::BlockSizeManagerV2::timeAfterUser() (qtconcurrentiteratekernel.cpp:195) Change-Id: I8c8e297a52caca38cd6191ae2653f2765d387077 Reviewed-by: Frederik Gladhorn --- src/concurrent/qtconcurrentmedian.h | 1 + 1 file changed, 1 insertion(+) (limited to 'src/concurrent') diff --git a/src/concurrent/qtconcurrentmedian.h b/src/concurrent/qtconcurrentmedian.h index 87e6b2935d..864b2d33d5 100644 --- a/src/concurrent/qtconcurrentmedian.h +++ b/src/concurrent/qtconcurrentmedian.h @@ -135,6 +135,7 @@ public: MedianDouble() : currentMedian(), currentIndex(0), valid(false), dirty(true) { + std::fill_n(values, static_cast(BufferSize), 0.0); } void reset() -- cgit v1.2.3