From 7bd3d4591a126cd99f797f1a9f83c966547e29e1 Mon Sep 17 00:00:00 2001 From: Allan Sandfeld Jensen Date: Mon, 5 Jan 2015 14:00:20 +0100 Subject: Fix authenticated POST/PUT http requests with buffering disabled If reset is disabled then POST and PUT requests can not be authenticated as the upload device can not be reset. There shouldn't be any reason that shouldn't be allowed if the QIODevice given supports resetting. The disableReset feature of QNonContiguousByteDevice is removed as it is not used anywhere else, and is redundant when reset can indicate success or failure. Task-number: QTBUG-43628 Change-Id: If941a98fd3f797872351c10bdca6aa6745dbefea Reviewed-by: Jocelyn Turcotte --- src/corelib/io/qnoncontiguousbytedevice_p.h | 3 --- 1 file changed, 3 deletions(-) (limited to 'src/corelib/io/qnoncontiguousbytedevice_p.h') diff --git a/src/corelib/io/qnoncontiguousbytedevice_p.h b/src/corelib/io/qnoncontiguousbytedevice_p.h index 1be28ff4b3..d36422e82c 100644 --- a/src/corelib/io/qnoncontiguousbytedevice_p.h +++ b/src/corelib/io/qnoncontiguousbytedevice_p.h @@ -62,8 +62,6 @@ public: virtual bool advanceReadPointer(qint64 amount) = 0; virtual bool atEnd() = 0; virtual bool reset() = 0; - void disableReset(); - bool isResetDisabled() { return resetDisabled; } virtual qint64 size() = 0; virtual ~QNonContiguousByteDevice(); @@ -72,7 +70,6 @@ protected: QNonContiguousByteDevice(); - bool resetDisabled; Q_SIGNALS: void readyRead(); void readProgress(qint64 current, qint64 total); -- cgit v1.2.3