From 08d20ee85092851547fb4dfee67e98bf7b37c936 Mon Sep 17 00:00:00 2001 From: Edward Welbourne Date: Mon, 21 Mar 2022 15:01:31 +0100 Subject: Use QByteArrayView more in QConfFileSettingsPrivate's methods Avoid allocating QBA methods when the QBAV methods can do just as well, especially where the QBA was already being QBAV-wrapped to avoid such allocations. Change-Id: I180c2316362685ffda613bab2c761e72c4483fce Reviewed-by: Sona Kurazyan Reviewed-by: Marc Mutz --- src/corelib/io/qsettings_p.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'src/corelib/io/qsettings_p.h') diff --git a/src/corelib/io/qsettings_p.h b/src/corelib/io/qsettings_p.h index ac82429146..a74e20ef55 100644 --- a/src/corelib/io/qsettings_p.h +++ b/src/corelib/io/qsettings_p.h @@ -231,10 +231,10 @@ public: static QString variantToString(const QVariant &v); static QVariant stringToVariant(const QString &s); static void iniEscapedKey(const QString &key, QByteArray &result); - static bool iniUnescapedKey(const QByteArray &key, int from, int to, QString &result); + static bool iniUnescapedKey(QByteArrayView key, int from, int to, QString &result); static void iniEscapedString(const QString &str, QByteArray &result); static void iniEscapedStringList(const QStringList &strs, QByteArray &result); - static bool iniUnescapedStringList(const QByteArray &str, int from, int to, + static bool iniUnescapedStringList(QByteArrayView str, int from, int to, QString &stringResult, QStringList &stringListResult); static QStringList splitArgs(const QString &s, int idx); @@ -276,10 +276,10 @@ public: bool isWritable() const override; QString fileName() const override; - bool readIniFile(const QByteArray &data, UnparsedSettingsMap *unparsedIniSections); - static bool readIniSection(const QSettingsKey §ion, const QByteArray &data, + bool readIniFile(QByteArrayView data, UnparsedSettingsMap *unparsedIniSections); + static bool readIniSection(const QSettingsKey §ion, QByteArrayView data, ParsedSettingsMap *settingsMap); - static bool readIniLine(const QByteArray &data, int &dataPos, int &lineStart, int &lineLen, + static bool readIniLine(QByteArrayView data, int &dataPos, int &lineStart, int &lineLen, int &equalsPos); private: -- cgit v1.2.3