From eb5654788b8c1662a4210e6c76c98abd509cf64f Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Sun, 17 May 2015 16:44:07 +0200 Subject: Micro-optimize QSettingsPrivate::processChild() and its users ...by using QStringRef instead of QString, avoiding one memory allocation in the case of spec != AllKeys and key containing a '/'. Also calls one less non-inline function, since QStringRef::truncated() is inline. Change-Id: Id5eb203006a3857508c5d3f4b729cde1a5170d58 Reviewed-by: Oswald Buddenhagen Reviewed-by: Olivier Goffart (Woboq GmbH) Reviewed-by: Thiago Macieira --- src/corelib/io/qsettings_p.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/corelib/io/qsettings_p.h') diff --git a/src/corelib/io/qsettings_p.h b/src/corelib/io/qsettings_p.h index 93d63fd411..004751182c 100644 --- a/src/corelib/io/qsettings_p.h +++ b/src/corelib/io/qsettings_p.h @@ -211,7 +211,7 @@ public: const QString &organization, const QString &application); static QSettingsPrivate *create(const QString &fileName, QSettings::Format format); - static void processChild(QString key, ChildSpec spec, QMap &result); + static void processChild(QStringRef key, ChildSpec spec, QMap &result); // Variant streaming functions static QStringList variantListToStringList(const QVariantList &l); -- cgit v1.2.3