From 8e9309934974c677545966902a79ea7084774e4c Mon Sep 17 00:00:00 2001 From: Ahmad Samir Date: Tue, 1 Nov 2022 18:09:55 +0200 Subject: QFileSystemMetaData: initialize integral members in-class Safer, this way ensures we don't have undefined behavior if one of those members is returned from a method before being initialized. Change-Id: I30da1837cea960d43b55259a3906d1aecbf722f4 Reviewed-by: Thiago Macieira --- src/corelib/io/qfilesystemmetadata_p.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'src/corelib/io') diff --git a/src/corelib/io/qfilesystemmetadata_p.h b/src/corelib/io/qfilesystemmetadata_p.h index 4be95faa1c..986ec5ca68 100644 --- a/src/corelib/io/qfilesystemmetadata_p.h +++ b/src/corelib/io/qfilesystemmetadata_p.h @@ -207,7 +207,7 @@ private: MetaDataFlags knownFlagsMask; MetaDataFlags entryFlags; - qint64 size_; + qint64 size_ = 0; // Platform-specific data goes here: #if defined(Q_OS_WIN) @@ -218,13 +218,13 @@ private: FILETIME lastWriteTime_; #else // msec precision - qint64 accessTime_; - qint64 birthTime_; - qint64 metadataChangeTime_; - qint64 modificationTime_; + qint64 accessTime_ = 0; + qint64 birthTime_ = 0; + qint64 metadataChangeTime_ = 0; + qint64 modificationTime_ = 0; - uint userId_; - uint groupId_; + uint userId_ = (uint) -2; + uint groupId_ = (uint) -2; #endif }; -- cgit v1.2.3