From 41418a92b7b490f3af5e2974cf4152c56e3d00fa Mon Sep 17 00:00:00 2001 From: Edward Welbourne Date: Mon, 8 Oct 2018 16:06:07 +0200 Subject: Remove spurious Q_FALLTHROUGH() Two cases with no code between them don't need a fall-through marker. The only code in the first case is subject to #if-ery; it either returns, without falling through, or has no code there. Putting in an overt Q_FALLTHROUGH() confused a rather dumb compiler ... Change-Id: Icc034be08859cc1656401af1c62367aec302668b Reviewed-by: Allan Sandfeld Jensen --- src/corelib/kernel/qsystemerror.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'src/corelib/kernel/qsystemerror.cpp') diff --git a/src/corelib/kernel/qsystemerror.cpp b/src/corelib/kernel/qsystemerror.cpp index 53c3136857..9d0394e4a5 100644 --- a/src/corelib/kernel/qsystemerror.cpp +++ b/src/corelib/kernel/qsystemerror.cpp @@ -152,10 +152,7 @@ QString QSystemError::string(ErrorScope errorScope, int errorCode) case NativeError: #if defined (Q_OS_WIN) return windowsErrorString(errorCode); -#else - //unix: fall through as native and standard library are the same - Q_FALLTHROUGH(); -#endif +#endif // else unix: native and standard library are the same case StandardLibraryError: return standardLibraryErrorString(errorCode); default: -- cgit v1.2.3