From f5654d909a7081fcc9f1091b2132fdcb07419776 Mon Sep 17 00:00:00 2001 From: Sergio Martins Date: Mon, 3 Dec 2018 22:58:29 +0000 Subject: Pass non-trivial types by const-ref in range-loop [-Wclazy-range-loop] corelib/serialization/qcbormap.h:176:14: warning: Missing reference in range-for with non trivial type (QPair) corelib/serialization/qjsoncbor.cpp:820:10: warning: Missing reference in range-for with non trivial type (QJsonValue) gui/kernel/qguiapplication.cpp:1171:10: warning: Missing reference in range-for with non trivial type (QString) printsupport/dialogs/qprintdialog_unix.cpp:741:10: warning: Missing reference in range-for with non trivial type (QString) printsupport/kernel/qprinter.cpp:1851:10: warning: Missing reference in range-for with non trivial type (QVariant) tools/qlalr/cppgenerator.cpp:463:8: warning: Missing reference in range-for with non trivial type (Name) Change-Id: I327b0f116e329e55952ed5740a5f5af4b2918392 Reviewed-by: Friedemann Kleint Reviewed-by: Thiago Macieira --- src/corelib/serialization/qcbormap.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/corelib/serialization/qcbormap.h') diff --git a/src/corelib/serialization/qcbormap.h b/src/corelib/serialization/qcbormap.h index 15a3bcdcef..4aea901eef 100644 --- a/src/corelib/serialization/qcbormap.h +++ b/src/corelib/serialization/qcbormap.h @@ -173,7 +173,7 @@ public: : QCborMap() { detach(args.size()); - for (auto pair : args) + for (const auto &pair : args) insert(pair.first, pair.second); } ~QCborMap(); -- cgit v1.2.3