From b58af67d7b5f22eaf2916b91d8a7060781203561 Mon Sep 17 00:00:00 2001 From: Thiago Macieira Date: Tue, 14 Feb 2017 12:13:53 -0800 Subject: Turn QThreadData::threadId into a QAtomicPointer Solves a data race found by TSan. Since thread and threadId are QAtomicPointer, I've removed the explicit initialization in the QThreadData constructor Task-number: QTBUG-58855 Change-Id: I4139d5f93dcb4b429ae9fffd14a34082f2683f76 Reviewed-by: Marc Mutz --- src/corelib/thread/qthread_p.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/corelib/thread/qthread_p.h') diff --git a/src/corelib/thread/qthread_p.h b/src/corelib/thread/qthread_p.h index 37eca9c612..885b4c0c1e 100644 --- a/src/corelib/thread/qthread_p.h +++ b/src/corelib/thread/qthread_p.h @@ -284,7 +284,7 @@ public: QStack eventLoops; QPostEventList postEventList; QAtomicPointer thread; - Qt::HANDLE threadId; + QAtomicPointer threadId; QAtomicPointer eventDispatcher; QVector tls; FlaggedDebugSignatures flaggedSignatures; -- cgit v1.2.3