From a5ff71578da5f6441ab8b07ae1fbf736d7f1e3ba Mon Sep 17 00:00:00 2001 From: Thiago Macieira Date: Fri, 2 Apr 2021 17:25:12 -0700 Subject: QRandomGenerator: let qt_initial_random_value() return 128 bits of data It's how much there is in Linux's AT_RANDOM block. I've also removed the check for validity. It's highly unlikely that 128 bits are bad. Change-Id: Id2983978ad544ff79911fffd16723161ea7ec315 Reviewed-by: Qt CI Bot Reviewed-by: Lars Knoll Reviewed-by: Allan Sandfeld Jensen --- src/corelib/tools/qhash.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/corelib/tools') diff --git a/src/corelib/tools/qhash.cpp b/src/corelib/tools/qhash.cpp index 380bc0d7ea..dcb90a530d 100644 --- a/src/corelib/tools/qhash.cpp +++ b/src/corelib/tools/qhash.cpp @@ -743,7 +743,8 @@ static size_t qt_create_qhash_seed(HashCreationMode mode) } seed = 1; // QHashSeed::globalSeed subtracts 1 } else if (mode == Initial) { - seed = qt_initial_random_value(); + auto data = qt_initial_random_value(); + seed = data.data[0] ^ data.data[1]; } else if (sizeof(seed) > sizeof(uint)) { seed = QRandomGenerator::system()->generate64(); } else { -- cgit v1.2.3