From bd6d706b69d8504d2a0e9402d1bc527ce6d8bf14 Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Tue, 6 Jul 2021 07:30:58 +0200 Subject: QCryptographicHash: make Private::method const It never changes, making it const might improve code-gen. Change-Id: Ife8723e27ae9cf6cfcca48d58d46307003123354 Reviewed-by: Lars Knoll --- src/corelib/tools/qcryptographichash.cpp | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) (limited to 'src/corelib/tools') diff --git a/src/corelib/tools/qcryptographichash.cpp b/src/corelib/tools/qcryptographichash.cpp index a93b546c77..473d2f1fb3 100644 --- a/src/corelib/tools/qcryptographichash.cpp +++ b/src/corelib/tools/qcryptographichash.cpp @@ -141,7 +141,12 @@ QT_BEGIN_NAMESPACE class QCryptographicHashPrivate { public: - QCryptographicHash::Algorithm method; + explicit QCryptographicHashPrivate(QCryptographicHash::Algorithm method) noexcept + : method(method) + { + } + + const QCryptographicHash::Algorithm method; union { Sha1State sha1Context; #ifndef QT_CRYPTOGRAPHICHASH_ONLY_SHA1 @@ -267,9 +272,8 @@ void QCryptographicHashPrivate::sha3Finish(int bitCount, Sha3Variant sha3Variant Constructs an object that can be used to create a cryptographic hash from data using \a method. */ QCryptographicHash::QCryptographicHash(Algorithm method) - : d(new QCryptographicHashPrivate) + : d(new QCryptographicHashPrivate{method}) { - d->method = method; reset(); } -- cgit v1.2.3