From 2eea6034bc98e201694cb419f606331e4ad07624 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C4=99drzej=20Nowacki?= Date: Wed, 30 Jul 2014 10:50:11 +0200 Subject: Micro-optimize QXmlStreamReaderPrivate. Avoid redundant QStringRef to QString conversions. Change-Id: I4a65119e7821206e2f72387a5d02cec5ce39dbfb Reviewed-by: Marc Mutz --- src/corelib/xml/qxmlstream.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/corelib/xml') diff --git a/src/corelib/xml/qxmlstream.cpp b/src/corelib/xml/qxmlstream.cpp index 69049aaccf..4b726a2295 100644 --- a/src/corelib/xml/qxmlstream.cpp +++ b/src/corelib/xml/qxmlstream.cpp @@ -1711,9 +1711,9 @@ uint QXmlStreamReaderPrivate::resolveCharRef(int symbolIndex) uint s; // ### add toXShort to QStringRef? if (sym(symbolIndex).c == 'x') - s = symString(symbolIndex, 1).toString().toUInt(&ok, 16); + s = symString(symbolIndex, 1).toUInt(&ok, 16); else - s = symString(symbolIndex).toString().toUInt(&ok, 10); + s = symString(symbolIndex).toUInt(&ok, 10); ok &= (s == 0x9 || s == 0xa || s == 0xd || (s >= 0x20 && s <= 0xd7ff) || (s >= 0xe000 && s <= 0xfffd) || (s >= 0x10000 && s <= QChar::LastValidCodePoint)); @@ -1773,7 +1773,7 @@ void QXmlStreamReaderPrivate::startDocument() { QString err; if (documentVersion != QLatin1String("1.0")) { - if (documentVersion.toString().contains(QLatin1Char(' '))) + if (documentVersion.contains(QLatin1Char(' '))) err = QXmlStream::tr("Invalid XML version string."); else err = QXmlStream::tr("Unsupported XML version."); -- cgit v1.2.3