From 130b2090147e0d28e35fd736fbefcd588c0014f6 Mon Sep 17 00:00:00 2001 From: Kai Koehne Date: Wed, 25 Nov 2020 17:21:09 +0100 Subject: Doc: Use explicit linkage with target_link_libraries The Professional CMake book suggests always using explicit linkage with target_link_libraries, so let's use that. Whether to use PUBLIC or PRIVATE depends on the context. But let's be conservative and advise on using PRIVATE by default. Task-number: QTBUG-88935 Pick-to: 6.0 Change-Id: I12b80ee85be9f6916f1e4dea6b1c9cb29e03c20f Reviewed-by: Craig Scott Reviewed-by: Alexandru Croitor --- src/dbus/doc/snippets/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/dbus/doc') diff --git a/src/dbus/doc/snippets/CMakeLists.txt b/src/dbus/doc/snippets/CMakeLists.txt index 87c7990972..825a088019 100644 --- a/src/dbus/doc/snippets/CMakeLists.txt +++ b/src/dbus/doc/snippets/CMakeLists.txt @@ -1,4 +1,4 @@ #! [cmake_use] find_package(Qt6 COMPONENTS DBus REQUIRED) -target_link_libraries(mytarget Qt6::DBus) +target_link_libraries(mytarget PRIVATE Qt6::DBus) #! [cmake_use] -- cgit v1.2.3