From 0ea39eb8420229a6ec96ed2bb0345c54d5cde976 Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Wed, 23 Dec 2015 00:15:30 +0100 Subject: QtDBus: eradicate all Q_FOREACH loops Saves a bit more than 0.5KiB in text size on optimized GCC 4.9 Linux AMD64 builds. Change-Id: I3b7e4751c4799c3e2c9f8f23b769e1659d863579 Reviewed-by: Thiago Macieira --- src/dbus/qdbusutil.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/dbus/qdbusutil.cpp') diff --git a/src/dbus/qdbusutil.cpp b/src/dbus/qdbusutil.cpp index 371b7b184e..04e805d173 100644 --- a/src/dbus/qdbusutil.cpp +++ b/src/dbus/qdbusutil.cpp @@ -77,8 +77,8 @@ static bool variantToString(const QVariant &arg, QString &out) if (argType == QVariant::StringList) { out += QLatin1Char('{'); - QStringList list = arg.toStringList(); - foreach (const QString &item, list) + const QStringList list = arg.toStringList(); + for (const QString &item : list) out += QLatin1Char('\"') + item + QLatin1String("\", "); if (!list.isEmpty()) out.chop(2); @@ -95,8 +95,8 @@ static bool variantToString(const QVariant &arg, QString &out) out += QLatin1Char('}'); } else if (argType == QVariant::List) { out += QLatin1Char('{'); - QList list = arg.toList(); - foreach (const QVariant &item, list) { + const QList list = arg.toList(); + for (const QVariant &item : list) { if (!variantToString(item, out)) return false; out += QLatin1String(", "); -- cgit v1.2.3