From 1b9d082bb88e561400d2614c0507f53da478d975 Mon Sep 17 00:00:00 2001 From: Peter Wu Date: Mon, 28 Mar 2016 19:43:08 +0200 Subject: dbus: make QDBusArgumentPrivate destructor virtual Make the destructor of QDBusArgumentPrivate virtual as it may store other types (QDBusDemarshaller). Suggested by Thiago. Fixes a "new-delete-type-mismatch" error reported by AddressSanitizer. Task-number: QTBUG-52176 Change-Id: I9ac19050840530ca9cae893b10093185d31e0448 Reviewed-by: Thiago Macieira Reviewed-by: Marc Mutz Reviewed-by: David Faure --- src/dbus/qdbusargument_p.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/dbus') diff --git a/src/dbus/qdbusargument_p.h b/src/dbus/qdbusargument_p.h index 28a3380fab..377cdf395b 100644 --- a/src/dbus/qdbusargument_p.h +++ b/src/dbus/qdbusargument_p.h @@ -66,7 +66,7 @@ public: inline QDBusArgumentPrivate(int flags = 0) : message(0), ref(1), capabilities(flags) { } - ~QDBusArgumentPrivate(); + virtual ~QDBusArgumentPrivate(); static bool checkRead(QDBusArgumentPrivate *d); static bool checkReadAndDetach(QDBusArgumentPrivate *&d); -- cgit v1.2.3