From 37a933c2b14a4a1aad54af0eba0bc210ae5b549a Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Tue, 26 Jan 2016 14:38:54 +0100 Subject: QtGui: eradicate Q_FOREACH loops [needing qAsConst()] ... by replacing them with C++11 range-for loops. To avoid detaches of these mutable Qt containers, wrap the container in qAsConst(). Change-Id: I90fd517ad542ef92034403c15ebb8300a56ac693 Reviewed-by: Lars Knoll Reviewed-by: Gunnar Sletta --- src/gui/itemmodels/qstandarditemmodel.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'src/gui/itemmodels/qstandarditemmodel.cpp') diff --git a/src/gui/itemmodels/qstandarditemmodel.cpp b/src/gui/itemmodels/qstandarditemmodel.cpp index e4442bb82f..e843351cf7 100644 --- a/src/gui/itemmodels/qstandarditemmodel.cpp +++ b/src/gui/itemmodels/qstandarditemmodel.cpp @@ -3032,9 +3032,8 @@ QMimeData *QStandardItemModel::mimeData(const QModelIndexList &indexes) const } stack.reserve(itemsSet.count()); - foreach (QStandardItem *item, itemsSet) { + for (QStandardItem *item : qAsConst(itemsSet)) stack.push(item); - } //stream everything recursively while (!stack.isEmpty()) { -- cgit v1.2.3